feat: upgrade rector, current rector is broken with latest phpstan release

.github/workflows/functional_test__rector_examples.yml

@@ -15,6 +15,7 @@ jobs:
     run_functional_test:
         name: Functional Test | PHP ${{ matrix.php-version }} | Drupal ${{ matrix.drupal }}"
         strategy:
+            fail-fast: false
             matrix:
                 include:
                     - php-version: "7.4"

composer.json

@@ -10,7 +10,7 @@
         "ast"
     ],
     "require": {
-        "rector/rector": "~0.18.0",
+        "rector/rector": "~0.19.0",
         "webflo/drupal-finder": "^1.2"
     },
     "license": "MIT",

config/drupal-8/drupal-8.2-deprecations.php

@@ -12,7 +12,7 @@
     });
     // https://www.drupal.org/node/2802569
     $rectorConfig->ruleWithConfiguration(FunctionToStaticRector::class, [
-        new \DrupalRector\Rector\ValueObject\FunctionToStaticConfiguration(
+        new DrupalRector\Rector\ValueObject\FunctionToStaticConfiguration(
             '8.2.0',
             'file_directory_os_temp',
             'Drupal\Component\FileSystem\FileSystem',

config/drupal-8/drupal-8.6-deprecations.php

@@ -10,7 +10,7 @@
     $rectorConfig->singleton(AddCommentService::class, function () {
         return new AddCommentService();
     });
-    $rectorConfig->ruleWithConfiguration(\DrupalRector\Drupal8\Rector\Deprecation\StaticToFunctionRector::class, [
+    $rectorConfig->ruleWithConfiguration(DrupalRector\Drupal8\Rector\Deprecation\StaticToFunctionRector::class, [
         // https://www.drupal.org/node/2850048
         new StaticToFunctionConfiguration('Drupal\Component\Utility\Unicode', 'strlen', 'mb_strlen'),
         // https://www.drupal.org/node/2850048

config/drupal-9/drupal-9.1-deprecations.php

@@ -42,7 +42,7 @@
     $rectorConfig->rule(AssertNoFieldByNameRector::class);
     $rectorConfig->rule(AssertFieldByIdRector::class);
 
-    $rectorConfig->ruleWithConfiguration(\DrupalRector\Drupal9\Rector\Deprecation\AssertLegacyTraitRector::class, [
+    $rectorConfig->ruleWithConfiguration(DrupalRector\Drupal9\Rector\Deprecation\AssertLegacyTraitRector::class, [
         new AssertLegacyTraitConfiguration('assertLinkByHref', 'linkByHrefExists'),
         new AssertLegacyTraitConfiguration('assertLink', 'linkExists'),
         new AssertLegacyTraitConfiguration('assertNoEscaped', 'assertNoEscaped'),

config/drupal-9/drupal-9.3-deprecations.php

@@ -33,9 +33,9 @@
     ]);
 
     // Change record: https://www.drupal.org/node/2940031
-    $rectorConfig->rule(\DrupalRector\Drupal9\Rector\Deprecation\FileCreateUrlRector::class);
-    $rectorConfig->rule(\DrupalRector\Drupal9\Rector\Deprecation\FileUrlTransformRelativeRector::class);
-    $rectorConfig->rule(\DrupalRector\Drupal9\Rector\Deprecation\FromUriRector::class);
+    $rectorConfig->rule(DrupalRector\Drupal9\Rector\Deprecation\FileCreateUrlRector::class);
+    $rectorConfig->rule(DrupalRector\Drupal9\Rector\Deprecation\FileUrlTransformRelativeRector::class);
+    $rectorConfig->rule(DrupalRector\Drupal9\Rector\Deprecation\FromUriRector::class);
 
     // Change record: https://www.drupal.org/node/3223520
     $rectorConfig->ruleWithConfiguration(FunctionToServiceRector::class, [

config/drupal-9/drupal-9.4-deprecations.php

@@ -4,5 +4,5 @@
 
 return static function (Rector\Config\RectorConfig $rectorConfig): void {
     // Change record https://www.drupal.org/node/3220952
-    $rectorConfig->rule(\DrupalRector\Drupal9\Rector\Deprecation\ModuleLoadRector::class);
+    $rectorConfig->rule(DrupalRector\Drupal9\Rector\Deprecation\ModuleLoadRector::class);
 };

phpstan-baseline.neon

@@ -109,3 +109,11 @@ parameters:
 			message: "#^Call to an undefined method PHPStan\\\\Type\\\\Type\\:\\:getValue\\(\\)\\.$#"
 			count: 1
 			path: src/Drupal9/Rector/Deprecation/ExtensionPathRector.php
+
+		-
+			message: """
+				#^Fetching deprecated class constant REMOVE_NODE of class PhpParser\\\\NodeTraverser\\:
+				Use NodeVisitor\\:\\:REMOVE_NODE instead\\.$#
+			"""
+			count: 1
+			path: src/Drupal9/Rector/Deprecation/PassRector.php

src/Drupal10/Rector/Deprecation/SystemTimeZonesRector.php

@@ -9,7 +9,7 @@
 use DrupalRector\Rector\ValueObject\DrupalIntroducedVersionConfiguration;
 use PhpParser\Node;
 use PhpParser\Node\Expr\ConstFetch;
-use Rector\Core\PhpParser\Node\Value\ValueResolver;
+use Rector\PhpParser\Node\Value\ValueResolver;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 

src/Drupal8/Rector/Deprecation/ConstantToClassConstantRector.php

@@ -6,8 +6,8 @@
 
 use DrupalRector\Drupal8\Rector\ValueObject\ConstantToClassConfiguration;
 use PhpParser\Node;
-use Rector\Core\Contract\Rector\ConfigurableRectorInterface;
-use Rector\Core\Rector\AbstractRector;
+use Rector\Contract\Rector\ConfigurableRectorInterface;
+use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 

src/Drupal8/Rector/Deprecation/DBRector.php

@@ -9,8 +9,8 @@
 use PhpParser\Node;
 use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\MethodCall;
-use Rector\Core\Contract\Rector\ConfigurableRectorInterface;
-use Rector\Core\Rector\AbstractRector;
+use Rector\Contract\Rector\ConfigurableRectorInterface;
+use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 

src/Drupal8/Rector/Deprecation/DrupalLRector.php

@@ -5,7 +5,7 @@
 namespace DrupalRector\Drupal8\Rector\Deprecation;
 
 use PhpParser\Node;
-use Rector\Core\Rector\AbstractRector;
+use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 

src/Drupal8/Rector/Deprecation/DrupalServiceRenameRector.php

@@ -6,8 +6,8 @@
 
 use DrupalRector\Drupal8\Rector\ValueObject\DrupalServiceRenameConfiguration;
 use PhpParser\Node;
-use Rector\Core\Contract\Rector\ConfigurableRectorInterface;
-use Rector\Core\Rector\AbstractRector;
+use Rector\Contract\Rector\ConfigurableRectorInterface;
+use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 

src/Drupal8/Rector/Deprecation/DrupalSetMessageRector.php

@@ -11,8 +11,8 @@
 use PHPStan\PhpDocParser\Ast\PhpDoc\GenericTagValueNode;
 use PHPStan\PhpDocParser\Ast\PhpDoc\PhpDocTagNode;
 use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfo;
-use Rector\Core\Rector\AbstractRector;
 use Rector\NodeTypeResolver\Node\AttributeKey;
+use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 

src/Drupal8/Rector/Deprecation/DrupalURLRector.php

@@ -5,7 +5,7 @@
 namespace DrupalRector\Drupal8\Rector\Deprecation;
 
 use PhpParser\Node;
-use Rector\Core\Rector\AbstractRector;
+use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 

src/Drupal8/Rector/Deprecation/EntityCreateRector.php

@@ -5,7 +5,7 @@
 namespace DrupalRector\Drupal8\Rector\Deprecation;
 
 use PhpParser\Node;
-use Rector\Core\Rector\AbstractRector;
+use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 

src/Drupal8/Rector/Deprecation/EntityDeleteMultipleRector.php

@@ -5,7 +5,7 @@
 namespace DrupalRector\Drupal8\Rector\Deprecation;
 
 use PhpParser\Node;
-use Rector\Core\Rector\AbstractRector;
+use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 

src/Drupal8/Rector/Deprecation/EntityInterfaceLinkRector.php

@@ -6,7 +6,7 @@
 
 use DrupalRector\Services\AddCommentService;
 use PhpParser\Node;
-use Rector\Core\Rector\AbstractRector;
+use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 

src/Drupal8/Rector/Deprecation/EntityLoadRector.php

@@ -7,8 +7,8 @@
 use DrupalRector\Drupal8\Rector\ValueObject\EntityLoadConfiguration;
 use DrupalRector\Services\AddCommentService;
 use PhpParser\Node;
-use Rector\Core\Contract\Rector\ConfigurableRectorInterface;
-use Rector\Core\Rector\AbstractRector;
+use Rector\Contract\Rector\ConfigurableRectorInterface;
+use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 
@@ -169,9 +169,15 @@ public function refactor(Node $node): ?Node
 
                     $resetCache_method_name = new Node\Identifier('resetCache');
 
+                    if (!class_exists('\PhpParser\Node\ArrayItem')) {
+                        $arrayItems = [new Node\Expr\ArrayItem($entity_id->value)];
+                    } else {
+                        $arrayItems = [new \PhpParser\Node\ArrayItem($entity_id->value)];
+                    }
+
                     $reset_args = [
                         // This creates a new argument that wraps the entity ID in an array.
-                        new Node\Arg(new Node\Expr\Array_([new Node\Expr\ArrayItem($entity_id->value)])),
+                        new Node\Arg(new Node\Expr\Array_($arrayItems)),
                     ];
 
                     $entity_load_reset_node = new Node\Expr\MethodCall($getStorage_node,

src/Drupal8/Rector/Deprecation/EntityManagerRector.php

@@ -7,10 +7,10 @@
 use DrupalRector\Services\AddCommentService;
 use PhpParser\Node;
 use PHPStan\Analyser\Scope;
-use Rector\Core\Exception\ShouldNotHappenException;
-use Rector\Core\Rector\AbstractRector;
+use Rector\Exception\ShouldNotHappenException;
 use Rector\NodeCollector\ScopeResolver\ParentClassScopeResolver;
 use Rector\NodeTypeResolver\Node\AttributeKey;
+use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 

src/Drupal8/Rector/Deprecation/EntityViewRector.php

@@ -5,7 +5,7 @@
 namespace DrupalRector\Drupal8\Rector\Deprecation;
 
 use PhpParser\Node;
-use Rector\Core\Rector\AbstractRector;
+use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 

src/Drupal8/Rector/Deprecation/FileDefaultSchemeRector.php

@@ -5,7 +5,7 @@
 namespace DrupalRector\Drupal8\Rector\Deprecation;
 
 use PhpParser\Node;
-use Rector\Core\Rector\AbstractRector;
+use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 

src/Drupal8/Rector/Deprecation/FunctionalTestDefaultThemePropertyRector.php

@@ -10,9 +10,9 @@
 use PHPStan\Analyser\Scope;
 use PHPStan\Type\ObjectType;
 use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfoFactory;
-use Rector\Core\Exception\ShouldNotHappenException;
-use Rector\Core\PhpParser\Node\Value\ValueResolver;
-use Rector\Core\Rector\AbstractScopeAwareRector;
+use Rector\Exception\ShouldNotHappenException;
+use Rector\PhpParser\Node\Value\ValueResolver;
+use Rector\Rector\AbstractScopeAwareRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 

src/Drupal8/Rector/Deprecation/GetMockRector.php

@@ -7,10 +7,10 @@
 use DrupalRector\Drupal8\Rector\ValueObject\GetMockConfiguration;
 use PhpParser\Node;
 use PHPStan\Analyser\Scope;
-use Rector\Core\Contract\Rector\ConfigurableRectorInterface;
-use Rector\Core\Rector\AbstractRector;
+use Rector\Contract\Rector\ConfigurableRectorInterface;
 use Rector\NodeCollector\ScopeResolver\ParentClassScopeResolver;
 use Rector\NodeTypeResolver\Node\AttributeKey;
+use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 

src/Drupal8/Rector/Deprecation/LinkGeneratorTraitLRector.php

@@ -7,8 +7,8 @@
 use DrupalRector\Services\AddCommentService;
 use DrupalRector\Utility\FindParentByTypeTrait;
 use PhpParser\Node;
-use Rector\Core\Rector\AbstractRector;
 use Rector\NodeTypeResolver\Node\AttributeKey;
+use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 

src/Drupal8/Rector/Deprecation/RequestTimeConstRector.php

@@ -5,7 +5,7 @@
 namespace DrupalRector\Drupal8\Rector\Deprecation;
 
 use PhpParser\Node;
-use Rector\Core\Rector\AbstractRector;
+use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 

src/Drupal8/Rector/Deprecation/SafeMarkupFormatRector.php

@@ -5,7 +5,7 @@
 namespace DrupalRector\Drupal8\Rector\Deprecation;
 
 use PhpParser\Node;
-use Rector\Core\Rector\AbstractRector;
+use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 

src/Drupal8/Rector/Deprecation/StaticToFunctionRector.php

@@ -6,8 +6,8 @@
 
 use DrupalRector\Drupal8\Rector\ValueObject\StaticToFunctionConfiguration;
 use PhpParser\Node;
-use Rector\Core\Contract\Rector\ConfigurableRectorInterface;
-use Rector\Core\Rector\AbstractRector;
+use Rector\Contract\Rector\ConfigurableRectorInterface;
+use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 

src/Drupal8/Rector/ValueObject/ConstantToClassConfiguration.php

@@ -4,7 +4,7 @@
 
 namespace DrupalRector\Drupal8\Rector\ValueObject;
 
-use Rector\Core\Validation\RectorAssert;
+use Rector\Validation\RectorAssert;
 
 final class ConstantToClassConfiguration
 {

src/Drupal8/Rector/ValueObject/EntityLoadConfiguration.php

@@ -4,7 +4,7 @@
 
 namespace DrupalRector\Drupal8\Rector\ValueObject;
 
-use Rector\Core\Validation\RectorAssert;
+use Rector\Validation\RectorAssert;
 
 final class EntityLoadConfiguration
 {

src/Drupal9/Rector/Deprecation/AssertFieldByIdRector.php

@@ -5,7 +5,7 @@
 namespace DrupalRector\Drupal9\Rector\Deprecation;
 
 use PhpParser\Node;
-use Rector\Core\Rector\AbstractRector;
+use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 

src/Drupal9/Rector/Deprecation/AssertFieldByNameRector.php

@@ -5,7 +5,7 @@
 namespace DrupalRector\Drupal9\Rector\Deprecation;
 
 use PhpParser\Node;
-use Rector\Core\Rector\AbstractRector;
+use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 

src/Drupal9/Rector/Deprecation/AssertLegacyTraitRector.php

@@ -10,8 +10,8 @@
 use PhpParser\Node;
 use PhpParser\Node\Arg;
 use PhpParser\Node\VariadicPlaceholder;
-use Rector\Core\Contract\Rector\ConfigurableRectorInterface;
-use Rector\Core\Rector\AbstractRector;
+use Rector\Contract\Rector\ConfigurableRectorInterface;
+use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 

src/Drupal9/Rector/Deprecation/AssertNoFieldByIdRector.php

@@ -5,7 +5,7 @@
 namespace DrupalRector\Drupal9\Rector\Deprecation;
 
 use PhpParser\Node;
-use Rector\Core\Rector\AbstractRector;
+use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 

src/Drupal9/Rector/Deprecation/AssertNoFieldByNameRector.php

@@ -9,7 +9,7 @@
 use PhpParser\Node;
 use PhpParser\Node\Arg;
 use PhpParser\Node\VariadicPlaceholder;
-use Rector\Core\Rector\AbstractRector;
+use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 

src/Drupal9/Rector/Deprecation/AssertNoUniqueTextRector.php

@@ -6,8 +6,8 @@
 
 use DrupalRector\Utility\GetDeclaringSourceTrait;
 use PhpParser\Node;
-use Rector\Core\Exception\ShouldNotHappenException;
-use Rector\Core\Rector\AbstractRector;
+use Rector\Exception\ShouldNotHappenException;
+use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 

src/Drupal9/Rector/Deprecation/AssertOptionSelectedRector.php

@@ -5,7 +5,7 @@
 namespace DrupalRector\Drupal9\Rector\Deprecation;
 
 use PhpParser\Node;
-use Rector\Core\Rector\AbstractRector;
+use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 

src/Drupal9/Rector/Deprecation/ConstructFieldXpathRector.php

@@ -6,7 +6,7 @@
 
 use DrupalRector\Utility\GetDeclaringSourceTrait;
 use PhpParser\Node;
-use Rector\Core\Rector\AbstractRector;
+use Rector\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;