Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds additional Composer patching configuration. #123

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

eric-schmidt
Copy link

User story: N/A

Description

  • Adds some additional patching configuration above and beyond what was added in WIP: Enable Composer patches from dependencies #121.
  • Additional configuration will force Composer to exit when a patch fails to apply, and will also ensure that Drupal Core is properly patched at the appropriate nesting level.

Testing instructions

  1. Run composer create-project palantirnet/drupal-skeleton example dev-add-additional-patching-config --no-interaction.
  2. Ensure that the project installed properly with no errors.

@eric-schmidt eric-schmidt self-assigned this Jan 17, 2022
@eric-schmidt
Copy link
Author

eric-schmidt commented Jan 17, 2022

@byrond @becw Adding this above and beyond the Composer patching added in #121, as I find this extra config to be super helpful (and it prevents some unexpected behavior, which has been encountered on some Palantir projects not adding this extra config). Let me know what you think 👍

@eric-schmidt eric-schmidt requested review from byrond and becw January 17, 2022 23:52
@becw becw merged commit 46b5532 into develop Jan 20, 2022
@becw becw deleted the add-additional-patching-config branch January 20, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants