Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Enable Composer patches from dependencies #121

Merged
merged 3 commits into from
Jan 7, 2022

Conversation

byrond
Copy link
Contributor

@byrond byrond commented Dec 23, 2021

Description

Updates composer.json to allow patches to be applied from dependencies.

This PR temporarily changes the version constraint of palantirnet/the-build to test a branch that contains a patch for Phing. That change should be reverted before this PR is merged.

Testing instructions

  • composer create-project palantirnet/drupal-skeleton example dev-composer-patches-dependencies --no-interaction
  • Verify the patch for Phing is installed (included in the detect-ddev-byron branch).

Open questions

Remaining tasks

  • Revert the changed version constraint of the-build after testing.

@byrond byrond self-assigned this Dec 23, 2021
@byrond byrond requested a review from becw December 23, 2021 16:41
@byrond byrond marked this pull request as draft December 23, 2021 16:41
Copy link
Member

@becw becw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@becw becw marked this pull request as ready for review January 7, 2022 19:36
@becw becw merged commit bbd445d into develop Jan 7, 2022
@becw becw deleted the composer-patches-dependencies branch January 7, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants