Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test drupal 10 #126

Merged
merged 29 commits into from
Jan 13, 2023
Merged

test drupal 10 #126

merged 29 commits into from
Jan 13, 2023

Conversation

byrond
Copy link
Contributor

@byrond byrond commented Aug 1, 2022

Description

A description of the changes. Consider including images/gifs to demonstrate behaviors (e.g. using Skitch or GIPHY Capture).

Testing instructions

  1. composer create-project palantirnet/drupal-skeleton drupal10 dev-drupal-10 --no-interaction
  2. cd drupal10
  3. Edit .ddev/config.yaml and change the name to drupal10
  4. ddev start
  5. ddev ssh
  6. vendor/bin/the-build-installer
  7. Visit https://drupal10.ddev.site/ and verify the site is running.
  8. Log in, and verify the site is running Drupal 10.

Remaining tasks

"drupal/workbench_tabs": "^1.5"
"composer/installers": "^2.0",
"drupal/admin_toolbar": "^3",
"drupal/config_split": "^1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to use config_split ^2 in another Drupal 10 project I set up. Not sure if we'll need to do that here as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.9 is compatible with Drupal 10, and 2.0.0 is still in pre-release, so I think we can leave this for now.

@byrond byrond removed the blocker label Jan 6, 2023
@Kbentham
Copy link
Contributor

I am seeing some errors that I think are related to this issue on the module and status pages https://www.drupal.org/project/drupal/issues/3293463

https://drupal10.ddev.site/admin/modules
Screen Shot 2023-01-11 at 1 47 00 PM

https://drupal10.ddev.site/admin/reports/status
Screen Shot 2023-01-11 at 1 47 24 PM
other than that this is looking good!

@byrond
Copy link
Contributor Author

byrond commented Jan 12, 2023

@Kbentham I added the patch in the Drupal core issue you found, but I still got the same error after first install and going to the status page. Clearing cache made the error go away. I removed the patch, so could you confirm that clearing cache after installing the site allows the status page to work?

@byrond byrond requested a review from Kbentham January 12, 2023 21:47
@byrond
Copy link
Contributor Author

byrond commented Jan 12, 2023

We might need to update The Build to clear cache when it's done switching the profile, so this manual step isn't required after running the first Drupal install.

Copy link
Contributor

@Kbentham Kbentham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@byrond byrond merged commit bea0ec2 into develop Jan 13, 2023
@byrond byrond deleted the drupal-10 branch January 13, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants