Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV-47: Update to PHP 8.2 #145

Merged
merged 6 commits into from
May 29, 2024
Merged

DEV-47: Update to PHP 8.2 #145

merged 6 commits into from
May 29, 2024

Conversation

byrond
Copy link
Contributor

@byrond byrond commented May 26, 2023

https://palantir.atlassian.net/browse/DEV-47

Update DDEV and CircleCI configs to use PHP 8.2

Open question: Do we need to update the composer.json minimum PHP version and readme? Yes

Testing

  • Follow the steps in the readme to create a new project using this branch (update-php-8.2). For the Composer command use:

composer create-project palantirnet/drupal-skeleton example dev-update-php-8.2 --no-interaction

@byrond byrond self-assigned this May 26, 2023
@becw
Copy link
Member

becw commented Jul 13, 2023

We talked about this in last week's devops meeting, and the main blocker is Drupal contrib compatibility. I don't think we have a clear view of what is and isn't compatible with PHP 8.2 yet, though -- we're in the middle of an update on a big site and that should flag any critical modules that would block this update. So, we'll hopefully be able to move on this by September.

@becw becw added the postponed label Aug 16, 2023
@becw becw changed the title Update to PHP 8.2 DEV-47: Update to PHP 8.2 Aug 17, 2023
README.md Outdated
* Check your PHP version from the command line using `php --version`
* If your project cannot support PHP 8.2, you should use PHP 8.1.18.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, I don't think so!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed!

@byrond byrond merged commit 65a217e into develop May 29, 2024
1 check passed
@byrond byrond deleted the update-php-8.2 branch May 29, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants