-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEV-47: Update to Node 18 and PHP 8.2 on CircleCI #222
Conversation
I would happily update the node version, but we're holding on updating to PHP 8.2 until we can better evaluate Drupal contrib compatibility (see related comment on the palantirnet/drupal-skeleton PR: palantirnet/drupal-skeleton#145 (comment)) |
README.md
Outdated
@@ -65,6 +65,10 @@ View a list of other available targets with: | |||
$> vendor/bin/phing -l | |||
``` | |||
|
|||
## Known Issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove this comment now that we're updating to PHP 8.2 on Circle?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep! Done.
https://palantir.atlassian.net/browse/DEV-47
This should be merged in tandem with palantirnet/drupal-skeleton#145