Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV-47: Update to Node 18 and PHP 8.2 on CircleCI #222

Merged
merged 8 commits into from
May 29, 2024
Merged

Conversation

byrond
Copy link
Contributor

@byrond byrond commented May 26, 2023

https://palantir.atlassian.net/browse/DEV-47

This should be merged in tandem with palantirnet/drupal-skeleton#145

  • Updates the default CircleCI config installed by The Build to use Node.js 18.
  • Updates the CircleCI config (plus installed versions and examples) to use PHP 8.2 on CircleCI.

@byrond byrond self-assigned this May 26, 2023
@byrond byrond changed the title Update to Node 18 on CircleCI Update to Node 18 and PHP 8.2 on CircleCI May 26, 2023
@becw
Copy link
Member

becw commented Aug 16, 2023

I would happily update the node version, but we're holding on updating to PHP 8.2 until we can better evaluate Drupal contrib compatibility (see related comment on the palantirnet/drupal-skeleton PR: palantirnet/drupal-skeleton#145 (comment))

@becw becw added the postponed label Aug 16, 2023
@becw becw changed the title Update to Node 18 and PHP 8.2 on CircleCI DEV-47: Update to Node 18 and PHP 8.2 on CircleCI Aug 17, 2023
@becw becw removed the postponed label May 29, 2024
README.md Outdated
@@ -65,6 +65,10 @@ View a list of other available targets with:
$> vendor/bin/phing -l
```

## Known Issues
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this comment now that we're updating to PHP 8.2 on Circle?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! Done.

@becw becw self-requested a review May 29, 2024 20:18
@becw becw merged commit 7f6eae3 into develop May 29, 2024
1 check passed
@becw becw deleted the update-node-18 branch May 29, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants