-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch Phing to fix relative symlinks #179
Conversation
src/TheBuild/IncludeResourceTask.php
Outdated
* | ||
* @var boolean | ||
*/ | ||
private $relative = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be protected
instead of private I think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and made this change.
@@ -0,0 +1,76 @@ | |||
diff --git a/classes/phing/tasks/ext/SymlinkTask.php b/classes/phing/tasks/ext/SymlinkTask.php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a README to the patches directory that explains where this patch comes from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and added a README.
I had two comments/change requests but otherwise this looks good. |
Description
the_build_utility
module, so it will be correct inside the DDEV container when created outside.IncludeResourceTask
to useSymlinkTask
in order to take advantage of required relative symlinks.This also requires adding
cweagans/composer-patches
and the following line tocomposer.json
, so the skeleton will need to be updated:Testing instructions
composer require cweagans/composer-patches
"enable-patching": true
to the"extra": { }
section ofcomposer.json
composer.json
to"palantirnet/the-build": "dev-detect-ddev-byron"
.composer update palantirnet/the-build
(You should see Composer remove Phing, reinstall it, and add the patch.)ddev start
(if the project isn't already running)ddev drush sql-drop
vendor/bin/the-build-installer