DEV-41 - Pin circle php image to 8.1.18. #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raylwalters
commented
Aug 16, 2023
| @@ -6,7 +6,7 @@ jobs: | |||
| build: | |||
| working_directory: ~/project | |||
| docker: | |||
| - image: cimg/php:8.1-browsers | |||
| - image: cimg/php:8.1.18-browsers | |||
There was a problem hiding this comment.
This can be reverted once the phpcs error is fixed, php/php-src#11972
There was a problem hiding this comment.
@raylwalters @becw based on the linked PHP issue, should we have pinned to 8.1.17?
There was a problem hiding this comment.
I thought we were having issues with 8.1.19. I have PNET pinned to 8.1.18 and haven't been seeing the errors.
becw
approved these changes
Aug 16, 2023
|
If you are having a memory leak in 8.1.19 this is unlikely to be because of the linked issue. Please open a new issue on php-src |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin circle php image to 8.1.18 to deal with phpcs out of memory bug on 8.1.19.
https://palantir.atlassian.net/browse/DEV-41