Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV-41 - Pin circle php image to 8.1.18. #227

Merged
merged 1 commit into from
Aug 16, 2023
Merged

DEV-41 - Pin circle php image to 8.1.18. #227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ jobs:
build:
working_directory: ~/project
docker:
- image: cimg/php:8.1-browsers
- image: cimg/php:8.1.18-browsers
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be reverted once the phpcs error is fixed, php/php-src#11972

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raylwalters @becw based on the linked PHP issue, should we have pinned to 8.1.17?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we were having issues with 8.1.19. I have PNET pinned to 8.1.18 and haven't been seeing the errors.

- image: cimg/mysql:5.7
command: --max_allowed_packet=16M
environment:
Expand Down