-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEV-25: Error reporting on "dirty directory" failures #230
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, @jaymejohnson! I viewed the CircleCI pipeline where this was tested, and the output looks good.
Once the spacing change on line 350 is reverted, this will be good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wahoo!
This PR adds extra output when a build fails due to a dirty artifact that lists the changed files.
To test: We will need to artificially create a dirty artifact scenario. Manually changing a composer.lock file to e.g. update
"plugin-api-version": "2.3.0" to "plugin-api-version": "2.6.0" did the job on the DHS project.
Testing steps
composer update palantirnet/the-build:dev-dev-25-dirty-artifact-reporting
and commit it.Note: When I was testing this initially I ran into an issue where it was never getting to the deploy step because circle would kill the build when the dirty repository checks were run in the step up step. If that happens, you can just comment out the lines in your project's
.circleci/config.yml
that are running the dirty repository checks.Link to example: https://app.circleci.com/pipelines/github/palantirnet/wisdhs-public/6655/workflows/72668daf-1094-4a61-bd7e-5d0723b5416f/jobs/16061