Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV-25: Error reporting on "dirty directory" failures #230

Merged
merged 13 commits into from
Nov 29, 2023
Merged

DEV-25: Error reporting on "dirty directory" failures #230

Changes from 12 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
491efb6
DEV-25: First stab at listing changed files when an artifact is dirty.
jaymejohnson Oct 27, 2023
b6ba6f1
Add Ray's phpmd version fix for testing.
jaymejohnson Oct 27, 2023
d82f395
Remove composer.lock
jaymejohnson Oct 27, 2023
18364d8
Undo the thing I tried.
jaymejohnson Oct 27, 2023
00c6513
Dev-25: Add some error formatting.
jaymejohnson Nov 8, 2023
90d4984
Experimenting with failing the build when repo is dirty.
jaymejohnson Nov 15, 2023
6cc7307
Dropping phpmd down to 2.13 to see if it fixes circle build error.
jaymejohnson Nov 15, 2023
44b2a70
Try using ready_to_build property instead of git diff.
jaymejohnson Nov 15, 2023
cb012f0
We can't use a git command bc artifact will not always run in a repo …
jaymejohnson Nov 15, 2023
c39ad06
Removing fail bc it doesn't do anything anyway.
jaymejohnson Nov 15, 2023
0cc77d2
Merge branch 'develop' into dev-25-dirty-artifact-reporting
jaymejohnson Nov 16, 2023
bfc1c1c
Clean up. dev-25-dirty-artifact-reporting
jaymejohnson Nov 16, 2023
f40c821
Remove whitespace.
jaymejohnson Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion targets/artifact.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@
<then>
<echo>Repository status: dirty</echo>
<echo level="error"> * You have changes which must be committed before you may build an artifact.</echo>
<echo level="error"> * Modified files: ${modified_files}</echo>
<property name="ready_to_build" value="n" />
</then>
<else>
Expand Down Expand Up @@ -346,5 +347,5 @@
<exec dir="${artifact.directory}" command="git branch -D ${artifact.git.temporary_branch}" checkreturn="true" logoutput="true" />
</target>


jaymejohnson marked this conversation as resolved.
Show resolved Hide resolved
</project>