Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom meta tag to show js smartbanner in newer iOS versions #24

Merged
merged 3 commits into from
Aug 22, 2017
Merged

Conversation

patw0929
Copy link
Owner

Fixed #23.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 85.926% when pulling ddddfee on t23 into 2b628ed on master.

@imdongchen
Copy link

Looks good to me.

Just curious, is there a reason people prefer to put the app info (app id, etc.) in the meta tag rather than in js? When I say 'people', I mean those smart banner libraries (including this one) all choose to do this way. I assume there must be a reason for that?

@patw0929
Copy link
Owner Author

Hmm... I guess it's a convention to put those information in meta tags. 😛

@imdongchen
Copy link

Hey, any plan to merge this pr soon?

@patw0929 patw0929 merged commit 8f66a30 into master Aug 22, 2017
@patw0929 patw0929 deleted the t23 branch August 22, 2017 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants