start-domain --debug=true does not display port number

[pzygielo]

start-domain --debug=true does not display port number

---

Expected Outcome

As described in

Payara/nucleus/admin/server-mgmt/src/main/manpages/com/sun/enterprise/admin/servermgmt/cli/start-domain.1

Lines 68 to 70 in c290512

	true
	The instance is started with JPDA debugging enabled and the
	port number for JPDA debugging is displayed.

I expect asadmin start-domain --debug=true to display port number used, i.e.:

Waiting for domain1 to start ............
Successfully started the domain : domain1
domain  Location: /tmp/payara5/glassfish/domains/domain1
Log File: /tmp/payara5/glassfish/domains/domain1/logs/server.log
Admin Port: 4848
Debugging is enabled.  The debugging port is: 9009
Command start-domain executed successfully.

Current Outcome

Waiting for domain1 to start ..............
Successfully started the domain : domain1
domain  Location: /tmp/payara5/glassfish/domains/domain1
Log File: /tmp/payara5/glassfish/domains/domain1/logs/server.log
Admin Port: 4848
Command start-domain executed successfully.

with no info on debug port used. To discover port used one has to for example inspect server.log or domain.xml.

Steps to reproduce

1. Start the domain (asadmin start-domain --debug=true)
2. Observe console output

Environment

• Payara Version: 5.194
• Edition: Full
• JDK Version: OpenJDK Runtime Environment (build 1.8.0_232-b09)
• Operating System: Linux
• Database: n/a

[dmatej]

Created internal issue CUSTCOM-81

[garbi]

This issue is still opened, right? I am using Payara 6.2 and there is still no indication that the server was started in debug mode, nor any indication of the actual JPDA port being used.

[pzygielo]

This issue is closed as indicated by its Status: Closed.

It works in version fixed by linked PR - 5.201/set as milestone, and also in the latest 5.x: 5.2022.5. All with JDK8.

The first 6 - 6.2021.1.Alpha1, also works when used with JDK 8 but not with JDK 11.

The next 6.2022.1.Alpha2 requires Java 11 (and does not display port used by debugger).

[pzygielo]

With Java newer than 8, the option line is built as -agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=*:9009, with port (9009) prefixed with host (*: here). This results again in port being discovered as -1 as code is not prepared for that part to be there. So this RE

Payara/nucleus/admin/launcher/src/main/java/com/sun/enterprise/admin/launcher/GFLauncher.java

Line 386 in 26c504b

Pattern portRegex = Pattern.compile(".*address=(?<port>\\d*).*");

needs to be adjusted (and perhaps the comment in

Payara/nucleus/admin/launcher/src/main/java/com/sun/enterprise/admin/launcher/GFLauncher.java

Line 371 in 26c504b

// -agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=9009

updated).

[pzygielo]

• CUSTCOM-264 Client mode debugging (server=no) doesn't work with JDK>=9 #4633

Rather that one:

• PAYARA-3577 Build Payara Server & Payara Micro using JDK8 and get them to pass the Test Suite #3905 (for the JavaConfig.java change)

It was already there when #4387 was created.