Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative links no longer working #486

Closed
greg0ire opened this issue Jul 9, 2023 · 0 comments
Closed

Relative links no longer working #486

greg0ire opened this issue Jul 9, 2023 · 0 comments

Comments

@greg0ire
Copy link
Contributor

greg0ire commented Jul 9, 2023

Since #480 , building the Doctrine ORM docs produces a lot of warnings:

[2023-07-09T14:28:52.000742+00:00] app.WARNING: Reference dql-user-defined-functions could not be resolved in cookbook/advanced-field-value-conversion-using-custom-mapping-types [] []
[2023-07-09T14:28:52.039679+00:00] app.WARNING: Reference ../reference/native-sql could not be resolved in cookbook/dql-user-defined-functions [] []
[2023-07-09T14:28:52.266874+00:00] app.WARNING: Reference ../reference/tools could not be resolved in reference/advanced-configuration [] []
[2023-07-09T14:28:52.294241+00:00] app.WARNING: Reference change-tracking-policies could not be resolved in reference/annotations-reference [] []
[2023-07-09T14:28:52.318856+00:00] app.WARNING: Reference namingstrategy could not be resolved in reference/annotations-reference [] []
[2023-07-09T14:28:52.332561+00:00] app.WARNING: Reference inheritance-mapping could not be resolved in reference/annotations-reference [] []
[2023-07-09T14:28:52.371021+00:00] app.WARNING: Reference /reference/inheritance-mapping could not be resolved in reference/architecture [] []
[2023-07-09T14:28:52.382536+00:00] app.WARNING: Reference unitofwork-associations could not be resolved in reference/association-mapping [] []
[2023-07-09T14:28:52.448356+00:00] app.WARNING: Reference change-tracking-policies could not be resolved in reference/attributes-reference [] []
[2023-07-09T14:28:52.471608+00:00] app.WARNING: Reference namingstrategy could not be resolved in reference/attributes-reference [] []
[2023-07-09T14:28:52.487268+00:00] app.WARNING: Reference inheritance-mapping could not be resolved in reference/attributes-reference [] []
[2023-07-09T14:28:52.515394+00:00] app.WARNING: Reference association-mapping could not be resolved in reference/basic-mapping [] []
[2023-07-09T14:28:52.517150+00:00] app.WARNING: Reference attributes-reference could not be resolved in reference/basic-mapping [] []
[2023-07-09T14:28:52.517443+00:00] app.WARNING: Reference xml-mapping could not be resolved in reference/basic-mapping [] []
[2023-07-09T14:28:52.517724+00:00] app.WARNING: Reference php-mapping could not be resolved in reference/basic-mapping [] []
[2023-07-09T14:28:52.517994+00:00] app.WARNING: Reference annotations-reference could not be resolved in reference/basic-mapping [] []
[2023-07-09T14:28:52.518598+00:00] app.WARNING: Reference yaml-mapping could not be resolved in reference/basic-mapping [] []
[2023-07-09T14:28:52.530743+00:00] app.WARNING: Reference tools could not be resolved in reference/basic-mapping [] []
[2023-07-09T14:28:52.540732+00:00] app.WARNING: Reference typedfieldmapper could not be resolved in reference/basic-mapping [] []
[2023-07-09T14:28:52.549471+00:00] app.WARNING: Reference ../cookbook/custom-mapping-types could not be resolved in reference/basic-mapping [] []
[2023-07-09T14:28:52.550768+00:00] app.WARNING: Reference ../cookbook/working-with-datetime could not be resolved in reference/basic-mapping [] []
[2023-07-09T14:28:52.558671+00:00] app.WARNING: Reference ../tutorials/composite-primary-keys could not be resolved in reference/basic-mapping [] []
[2023-07-09T14:28:52.599000+00:00] app.WARNING: Reference /reference/advanced-configuration could not be resolved in reference/configuration [] []
[2023-07-09T14:28:52.600154+00:00] app.WARNING: Reference ../reference/tools could not be resolved in reference/configuration [] []
[2023-07-09T14:28:52.675498+00:00] app.WARNING: Reference /reference/batch-processing could not be resolved in reference/dql-doctrine-query-language [] []
[2023-07-09T14:28:52.719824+00:00] app.WARNING: Reference /tutorials/embeddables could not be resolved in reference/events [] []
[2023-07-09T14:28:52.769107+00:00] app.WARNING: Reference ../tutorials/composite-primary-keys could not be resolved in reference/faq [] []
[2023-07-09T14:28:52.772181+00:00] app.WARNING: Reference inheritance-mapping could not be resolved in reference/faq [] []
[2023-07-09T14:28:52.792793+00:00] app.WARNING: Reference ../tutorials/extra-lazy-associations could not be resolved in reference/improving-performance [] []
[2023-07-09T14:28:52.794328+00:00] app.WARNING: Reference /reference/best-practices could not be resolved in reference/improving-performance [] []
[2023-07-09T14:28:52.794956+00:00] app.WARNING: Reference change-tracking-policies could not be resolved in reference/improving-performance [] []
[2023-07-09T14:28:52.797706+00:00] app.WARNING: Reference /cookbook/resolve-target-entity-listener could not be resolved in reference/inheritance-mapping [] []
[2023-07-09T14:28:52.799499+00:00] app.WARNING: Reference /reference/limitations-and-known-issues could not be resolved in reference/inheritance-mapping [] []
[2023-07-09T14:28:52.812724+00:00] app.WARNING: Reference /reference/limitations-and-known-issues could not be resolved in reference/inheritance-mapping [] []
[2023-07-09T14:28:52.820413+00:00] app.WARNING: Reference /reference/configuration could not be resolved in reference/installation [] []
[2023-07-09T14:28:52.831672+00:00] app.WARNING: Reference /tutorials/override-field-association-mappings-in-subclasses could not be resolved in reference/limitations-and-known-issues [] []
[2023-07-09T14:28:52.835719+00:00] app.WARNING: Reference basic-mapping could not be resolved in reference/limitations-and-known-issues [] []
[2023-07-09T14:28:52.920358+00:00] app.WARNING: Reference faq could not be resolved in reference/query-builder [] []
[2023-07-09T14:28:53.051664+00:00] app.WARNING: Reference change-tracking-policies could not be resolved in reference/unitofwork [] []
[2023-07-09T14:28:53.060309+00:00] app.WARNING: Reference unitofwork-associations could not be resolved in reference/working-with-associations [] []
[2023-07-09T14:28:53.076708+00:00] app.WARNING: Reference working-with-objects could not be resolved in reference/working-with-associations [] []
[2023-07-09T14:28:53.137645+00:00] app.WARNING: Reference working-with-associations could not be resolved in reference/working-with-objects [] []
[2023-07-09T14:28:53.140195+00:00] app.WARNING: Reference dql-doctrine-query-language could not be resolved in reference/working-with-objects [] []
[2023-07-09T14:28:53.140618+00:00] app.WARNING: Reference query-builder could not be resolved in reference/working-with-objects [] []
[2023-07-09T14:28:53.141317+00:00] app.WARNING: Reference native-sql could not be resolved in reference/working-with-objects [] []
[2023-07-09T14:28:53.478732+00:00] app.WARNING: Reference getting-started could not be resolved in tutorials/getting-started-database [] []
[2023-07-09T14:28:53.478990+00:00] app.WARNING: Reference getting-started-models could not be resolved in tutorials/getting-started-database [] []
[2023-07-09T14:28:53.481349+00:00] app.WARNING: Reference getting-started could not be resolved in tutorials/getting-started-models [] []
[2023-07-09T14:28:53.481600+00:00] app.WARNING: Reference getting-started-database could not be resolved in tutorials/getting-started-models [] []
[2023-07-09T14:28:53.494913+00:00] app.WARNING: Reference ../reference/configuration could not be resolved in tutorials/getting-started [] []
[2023-07-09T14:28:53.496407+00:00] app.WARNING: Reference ../reference/tools could not be resolved in tutorials/getting-started [] []

It seems relative links can no longer be resolved. @wouterj can you please help with this? 🙏

greg0ire added a commit to greg0ire/guides that referenced this issue Jul 11, 2023
The method ProjectNode::findDocumentEntry() expects canonicalized urls,
and we fed it URLs that might be relative, leading to links not being
resolved.

Fixes phpDocumentor#486
greg0ire added a commit to greg0ire/guides that referenced this issue Jul 11, 2023
The method ProjectNode::findDocumentEntry() expects canonicalized urls,
and we fed it URLs that might be relative, leading to links not being
resolved.

Fixes phpDocumentor#486
@jaapio jaapio closed this as completed in b518c86 Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant