Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add peer review system for queries #1535

Merged
merged 37 commits into from
Feb 5, 2025

Conversation

zhangvi7
Copy link
Contributor

@zhangvi7 zhangvi7 commented Jan 30, 2025

Context

This update introduces a Query Review System to Querybook, which enhances the security of query executions by ensuring that important and sensitive queries can be reviewed by peers before they are executed.

Changes

  • Peer review request modal: Request a new review
  • Review panel: View all reviews
  • Reviewer View: Approve/Reject a query in a Query Execution view
  • DB Migration: query_review
  • New Plugins: query_review_handler_plugin and notification_templates_plugin
  • Notification logic: On approve, reject, request review
  • Misc: review endpoint, redux updates, public config changes, frontend changes

TODO:

  • Websocket changes to update review updates on UI
  • Documentation
  • Ability to copy paste review link

Victor and others added 2 commits February 3, 2025 17:19
jczhong84
jczhong84 previously approved these changes Feb 4, 2025
ui: Peer review UI improvements
@zhangvi7 zhangvi7 requested a review from jczhong84 February 5, 2025 15:33
@zhangvi7 zhangvi7 merged commit 34e1cd2 into pinterest:master Feb 5, 2025
4 checks passed
@zhangvi7 zhangvi7 deleted the peer_review branch February 5, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants