Use Webpack 2 #34
Closed
Use Webpack 2 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecated as of React v15.5
This stays away from Webpack dependencies, which are more-easily bumped after Webpack itself is bumped. - vinyl to ^2 - url-join to ^2 - multipipe to ^1 - loader-utils to ^1 - gulp-sourcemaps to ^2 - gulp-sass to ^3 - libsass from 3.3.2 to 3.4.3 - gulp-progeny to ^0.4 - progeny from 0.7 to 0.11 - gulp-filter to ^5 - foreman to ^2 - babel-eslint to ^7 - Drops support for Node < 4 - npm to ^4
Remove unused packages
- gulp-env
- gulp-livereload
- gulp-tap
- gulp-wait
- lodash.debounce
- lsof
- portfinder
- react-addons-test-utils
- babel-preset-es2015-loose
- This is deprecated. As of Babel v6.13+, babel-preset-es2015 has a built-in
loose option.
extract-text-webpack-plugin must also be bumped to ^2 webpack-stream uses Webpack 1, so we must pass it Webpack 2 Both bumps introduce some deprecations that are cleaned up here: - Webpack refuses a config with extra properties, including "browserAppAssetsOptions". A `delete` isn't the best, but works. I'd rather someone with more familiarity with the codebase perform the correct refactor. - Webpack loader definition has changed, including using "rules" and requiring the "-loader" suffix - extract-text-webpack-plugin syntax is slightly changed - `externals` and `quiet` are no longer accepted Webpack config keys - noErrors is deprecated in favor of noEmitErrors - UglifyJsPlugin defaults are changed to match the previous explicit config
- babel-loader to ^7 - Drops support for Node < 4 and Webpack 1 - sass-loader to ^6 - Drops support for node-sass 3 and webpack 1 - Drops support for synchronous compilation - file-loader to ^0.11 - css-loader to ^0.28 - style-loader to ^0.16
|
Thanks Dan, I ended up finishing the bigger webpack 2 upgrade instead of taking the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #33 and updates to Webpack 2 (technically, this PR brings in Webpack as an explicit dependency at all).
Webpack 2 introduces some breaking changes and requires some bumps to other packages, so that's taken care of in this as well. I tested that things were working by running all the gulp tasks in pivotal-cf/react-starter using this branch of pui-react-tools.
To test this on your own, you will need to:
require('babel-loaderinstead ofrequire('babelinapp/index.js