Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated strings should be null terminated #16

Closed
TethysSvensson opened this issue Dec 19, 2021 · 1 comment
Closed

Generated strings should be null terminated #16

TethysSvensson opened this issue Dec 19, 2021 · 1 comment

Comments

@TethysSvensson
Copy link
Collaborator

TethysSvensson commented Dec 19, 2021 •
edited
Loading

I don't know if they are already null terminated, but in any case we also need to add a test for it.
@TethysSvensson TethysSvensson changed the title Double check if our generated strings are null terminated Generated strings should be null terminated Dec 26, 2021
@TethysSvensson TethysSvensson mentioned this issue Jan 3, 2022
Closed
TethysSvensson added a commit that referenced this issue Jan 4, 2022
@TethysSvensson
Fix issue #16
069d4cb
TethysSvensson added a commit that referenced this issue Jan 4, 2022
@TethysSvensson
Add null terminators to strings
b82900f 
* Adds null terminators to the end of written strings to fix issue #16
* Adds optional null terminator validation while deserializing gated
  behind a new `extra-validation` feature flag.
* Adds extensive testing for the fix.
* Slightly changes the debug output for deserialized tables.
@TethysSvensson TethysSvensson mentioned this issue Jan 4, 2022
Merged
TethysSvensson added a commit that referenced this issue Jan 4, 2022
@TethysSvensson
Add null terminators to strings (#36)
ce0605d 
* Add null terminators to strings

* Adds null terminators to the end of written strings to fix issue #16
* Adds optional null terminator validation while deserializing gated
  behind a new `extra-validation` feature flag.
* Adds extensive testing for the fix.
* Slightly changes the debug output for deserialized tables.

* Add safety comments
@TethysSvensson
Copy link
Collaborator Author

Fixed in #36.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TethysSvensson