Add null terminators to strings #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds null terminators to the end of written strings to fix issue #16 * Adds optional null terminator validation while deserializing gated behind a new `extra-validation` feature flag. * Adds extensive testing for the fix. * Slightly changes the debug output for deserialized tables.
|
cc: @jorgecarleitao |
|
I can recommend the filtering options in the "files changed" pane when reviewing this PR. |
kristoff3r
reviewed
Jan 4, 2022
kristoff3r
approved these changes
Jan 4, 2022
This was referenced Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
behind a new
extra-validationfeature flag.