Merge pull request #4140 from plotly/mirror-all-not-mirror-allticks

Don't draw ticks on tick subplots when mirror:'all'

src/plots/cartesian/axes.js

@@ -1759,7 +1759,9 @@ axes.drawOne = function(gd, ax, opts) {
             transFn: transFn
         });
 
-        tickSubplots = Object.keys(ax._linepositions || {});
+        if(ax.mirror === 'allticks') {
+            tickSubplots = Object.keys(ax._linepositions || {});
+        }
     }
 
     for(i = 0; i < tickSubplots.length; i++) {

test/image/mocks/mirror-all-vs-allticks.json

@@ -0,0 +1,57 @@
+{
+  "data": [
+    {
+      "x": [1, 2, 3],
+      "y": [4, 5, 6]
+    },
+    {
+      "x": [20, 30, 40],
+      "y": [50, 60, 70],
+      "xaxis": "x2"
+    },
+    {
+      "x": [1, 2, 3],
+      "y": [4, 5, 6],
+      "yaxis": "y2"
+    },
+    {
+      "x": [20, 30, 40],
+      "y": [50, 60, 70],
+      "xaxis": "x2",
+      "yaxis": "y2"
+    }
+  ],
+  "layout": {
+    "showlegend": false,
+    "grid": {
+      "rows": 2,
+      "columns": 2
+    },
+    "xaxis": {
+      "title": {"text": "mirror:all"},
+      "ticks": "outside",
+      "showline": true,
+      "mirror": "all"
+    },
+    "xaxis2": {
+      "title": {"text": "mirror:allticks"},
+      "ticks": "outside",
+      "showline": true,
+      "mirror": "allticks"
+    },
+    "yaxis": {
+      "title": {"text": "mirror:all"},
+      "ticks": "outside",
+      "showline": true,
+      "zeroline": false,
+      "mirror": "all"
+    },
+    "yaxis2": {
+      "title": {"text": "mirror:allticks"},
+      "ticks": "outside",
+      "showline": true,
+      "zeroline": false,
+      "mirror": "allticks"
+    }
+  }
+}