fix #4136 - don't draw ticks corresponding to _linepositions

... when mirror isn't 'allticks' as _linepositions gets filled in lsInner (in subroutines.js) when mirror is set to 'all' OR 'allticks'
plotly · Aug 20, 2019 · cc19178 · cc19178
1 parent 8f6e919
commit cc19178
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/plots/cartesian/axes.js b/src/plots/cartesian/axes.js
@@ -1759,7 +1759,9 @@ axes.drawOne = function(gd, ax, opts) {
             transFn: transFn
         });
 
-        tickSubplots = Object.keys(ax._linepositions || {});
+        if(ax.mirror === 'allticks') {
+            tickSubplots = Object.keys(ax._linepositions || {});
+        }
     }
 
     for(i = 0; i < tickSubplots.length; i++) {

diff --git a/test/image/baselines/mirror-all-vs-allticks.png b/test/image/baselines/mirror-all-vs-allticks.png