Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mirror: "all" - all axis lines and ticks are mirrored #4136

Closed
DaanyWaay opened this issue Aug 19, 2019 · 2 comments · Fixed by #4140
Closed

mirror: "all" - all axis lines and ticks are mirrored #4136

DaanyWaay opened this issue Aug 19, 2019 · 2 comments · Fixed by #4140
Assignees
@etpinard
Labels
bug something broken

Comments

@DaanyWaay
Copy link

DaanyWaay commented Aug 19, 2019 •
edited
Loading

Ticks should be mirrored only if "allticks" is selected.
https://codepen.io/pen/ZEzpYWY
@etpinard
Copy link
Contributor

essential the bug part of #2539 - thanks very much for posting!

@etpinard etpinard added the bug something broken label Aug 20, 2019
@etpinard etpinard self-assigned this Aug 20, 2019
etpinard added a commit that referenced this issue Aug 20, 2019
@etpinard
add failing mock for #4136
8f6e919
etpinard added a commit that referenced this issue Aug 20, 2019
@etpinard
fix #4136 - don't draw ticks corresponding to _linepositions
cc19178 
... when mirror isn't 'allticks' as _linepositions gets
    filled in lsInner (in subroutines.js) when mirror is set
    to 'all' OR 'allticks'
@etpinard etpinard mentioned this issue Aug 20, 2019
Merged
@thchr
Copy link

thchr commented Jul 22, 2021

I noted this over in #4140 but realized it might make more sense to note it in this issue instead:

This seems to still be be broken on v2.2.1: https://codepen.io/thchr/pen/eYWGjQM
I.e., the tick marks are on both y-axes of the first subplot.

@thchr thchr mentioned this issue Jul 26, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@etpinard etpinard

Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't draw ticks on tick subplots when mirror:'all' plotly/plotly.js
3 participants
@etpinard @thchr @DaanyWaay