-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
De-circularize plotly.js require statements #236
Comments
The World Calendar push of #1220 added a new circular dependency pattern to as To solve this, we can either:
|
In the course of #1403 I made some circular deps involving |
Refer to PR #2032 for the most up-to-date findings. |
@mdtusz
Latest list of circular dependencies:
Plots
calls inaxes.js
aretraceIs
)Possible partial solutions:
plot_api.js
doesn't have to require the full component modules (similar to trace and subplot modules). Blocking: we'll need a centralized api for the component module, e.g. all component modules should have adraw
method and possible andinit
method.relayout
andrestyle
to a plot object so that files requiringplot_api.js
(e.g Annotations, Shapes and Fx) can usegd.relayout()
instead ofplotApi.relayout(gd, ...)
.The text was updated successfully, but these errors were encountered: