Fx component #1613
Merged
Fx component #1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- into component/fx/ - keep old 'init' routine in graph_interact.js - mv hover constants out of cartesian constants.js and into fx/
etpinard
commented
Apr 20, 2017
|
|
||
| 'use strict'; | ||
|
|
||
| module.exports = { |
There was a problem hiding this comment.
@alexcjohnson can you think of anything else that might be better off in here?
There was a problem hiding this comment.
nope, I think you got it all!
|
Nicely done! 💃 |
- this removes one more circular dep!
etpinard
added a commit
that referenced
this pull request
Apr 25, 2017
- somehow `madge` identifies circular in an order-dependent way, bump back to pre PR #1613 value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to be merged in #1582
Introducing
src/components/fx/home to all things hover. As hover logic is becoming more and more centralized and less and less cartesian-only, moving this out ofsrc/plots/cartesian/is a no-brainer.Down the road (maybe in this PR if easy) we should make
Fxa optionally registerable component so that we can remove from ourlib/core.jsmodule, making for smaller custom bundles for users not caring about hover labels. Note thatsrc/components/fx/hover.jsis over 1000 LOC.As a bonus, this reorganisation removed
45 circular dependencies fromsrc/(ref #236) 🎉