Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in simple zoom in #3943

Closed
michalwoz opened this issue Jun 7, 2019 · 1 comment · Fixed by #3950
Closed

Bug in simple zoom in #3943

michalwoz opened this issue Jun 7, 2019 · 1 comment · Fixed by #3950
Assignees
@etpinard
Labels
bug something broken

Comments

@michalwoz
Copy link

michalwoz commented Jun 7, 2019 •
edited
Loading

There is little bug in zooming in. When you click and release in parallel point to axis you can see two vertical or horizontal lines: A
image
and zoom in "range mode" on x or y axis.

When you click not in parallel you can go to "rectangle zoom mode": B
image

The problem is that when your mouse move during click and release is not almost perfectly parallel to axis you see parallel lines(picture A), but in effect you get zoom in rectangle mode. I experience it in simplest plotly configuration.

you can easily recreate this on
https://plot.ly/~demos/1414

by releasing mouse click zoom at this point:
image
@etpinard
Copy link
Contributor

Got it:

Peek 2019-06-10 10-15

Thanks for letting us know @michalwoz !!

@etpinard etpinard added the bug something broken label Jun 10, 2019
@etpinard etpinard self-assigned this Jun 10, 2019
etpinard added a commit that referenced this issue Jun 11, 2019
@etpinard
fix #3943 - don't mutate fullLayout ax ranges during zoombox mousemove
69cb628 
- first reason, why don't need to
- second reason, mutation aren't reset meaning going from 2d back to 1d
  zoombox lead to wrong rendering after mouseup and a discrepency
  between gd.layout(x|y).range and gd._fullLayout(x|y).range values
etpinard added a commit that referenced this issue Jun 11, 2019
@etpinard
fix #3943 - don't mutate fullLayout ax ranges during zoombox mousemove
8d0ccb1 
- first reason, why don't need to
- second reason, mutation aren't reset meaning going from 2d back to 1d
  zoombox lead to wrong rendering after mouseup and a discrepency
  between gd.layout(x|y).range and gd._fullLayout(x|y).range values
@etpinard etpinard mentioned this issue Jun 11, 2019
Merged
zenixls2 pushed a commit to zenixls2/plotly.js that referenced this issue Jun 17, 2019
Merge branch 'master' into hotfix/error_resize
089aab6 
* master: (21 commits)
  1.48.3
  update changelog for 1.48.3
  clean up fx helpers from funnel info - cleanup custom_assertions from isEmpty hack
  revert es6-promise and topojson-client versions
  revise funnel hovertemplate and hoverinfo based on comments
  fix issue 3954 - implement hoverinfo and hovertemplate for funnel percentages
  bump es6-promise and topojson-client - uninstall font-atlas-sdf
  bump js-yaml to 3.13.1
  bump ecstatic to 3.3.2
  1.48.2
  update changelog for 1.48.2
  bump delays during legend interactions tests
  bump tolenrance in sankey suite
  bump tolerence in Drawing.bbox test
  use assets/drag.js across test suites
  bump tolerence in multicategory tick label test
  fix plotly#3943 - don't mutate fullLayout ax ranges during zoombox mousemove
  adapt test suites that require assets/drag.js
  generalize assets/drag.js
  bump tinycolor2 to 1.4.1 - bump few dev-deps too
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@etpinard etpinard

Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1d -> 2d -> 1d zoombox regression fix + drag test maintenance plotly/plotly.js
2 participants
@etpinard @michalwoz