1d -> 2d -> 1d zoombox regression fix + drag test maintenance #3950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- to accept `path` (on top of dpos/pos0) - to accept `touch` option to emulate touch drag
- first reason, why don't need to - second reason, mutation aren't reset meaning going from 2d back to 1d zoombox lead to wrong rendering after mouseup and a discrepency between gd.layout(x|y).range and gd._fullLayout(x|y).range values
... to pass on etpinard's laptop running Chrome 70
... to pass ok on etpinard's laptop running Chrome 70
... to make test pass ok on etpinard's laptop running Chrome 70
... to alleviate problems when running full `npm run test-jasmine`
suite at once.
etpinard
commented
Jun 11, 2019
| * - {function} start | ||
| * - {function} end | ||
| */ | ||
| function makeFns(opts) { |
There was a problem hiding this comment.
We can now use the same drag helpers by passing a path, start/end position, start position + delta, etc..
|
Looking good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 8d0ccb1 fixes #3943 a regression that slipped in 1.48.0 via the
plotly_relayoutingPR #3888before https://codepen.io/etpinard/pen/jjEWyR?editors=1010
after https://codepen.io/etpinard/pen/GbgoWx?editors=1010
commit 8806fb7 generalizes our
test/jasmine/assets/drag.jshelpers, so that we can use them almost everywhere with ee74b28 and c48b5bf. This should make some of our tests less flaky.The other commits bumped a few tolerance values to make the tests ✅ on my laptop running Chrome 70
@plotly/plotly_js looking for a quick review to release 1.48.2 asap. Thanks!