Code

ZERO circular dependency #2429

Code

Merged

etpinard merged 17 commits intomasterplotly/plotly.js:masterfrom zero-circular-depplotly/plotly.js:zero-circular-depCopy head branch name to clipboardMar 2, 2018

+920-1,009

Commits

Commits on Mar 1, 2018

• move grid module to components/

  Show description for bee37dd
  etpinard

  committed
  bee37dd

  Copy full SHA for bee37dd

• merge src/plot_api/register.js into src/registry.js

  Show description for 973abbc
  etpinard

  committed
  973abbc

  Copy full SHA for 973abbc

• fixes #621 - make x/y/z dependent error bar attributes

  Show description for b08c402
  etpinard

  committed
  b08c402

  Copy full SHA for b08c402

• use errorbars methods via getComponentMethod

  Show description for 87275af
  etpinard

  committed
  87275af

  Copy full SHA for 87275af

• add apiMethodRegistry in src/registry

  Show description for 52b83b3
  etpinard

  committed
  52b83b3

  Copy full SHA for 52b83b3

• add Registry.call method + use it to 🔪 circular deps !!!

  etpinard

  committed
  9fc8832

  Copy full SHA for 9fc8832

• move Plotly.setPlotConfig to plot_api.js

  etpinard

  committed
  381b6e4

  Copy full SHA for 381b6e4

• use Registry.traceIs instead of plots.traceIs copy

  etpinard

  committed
  ed8d56d

  Copy full SHA for ed8d56d

• 🔪 src/plotly.js !!!

  etpinard

  committed
  204799c

  Copy full SHA for 204799c

• 🔒 down circular dep test at 0️⃣

  etpinard

  committed
  2c529ec

  Copy full SHA for 2c529ec

• update tests (mostly update ref to spyOn modules)

  etpinard

  committed
  c6df699

  Copy full SHA for c6df699

• add flaky tag to scattergl visible toggle test

  etpinard

  committed
  011443e

  Copy full SHA for 011443e

Commits on Mar 2, 2018

• grab Grid module method using Registry.getComponentMethod

  etpinard

  committed
  9246fda

  Copy full SHA for 9246fda

• fix typo in test_syntax

  etpinard

  committed
  d27b3ba

  Copy full SHA for d27b3ba

• rename register_test -> registry_test & improve it!

  Show description for e05f4f0
  etpinard

  committed
  e05f4f0

  Copy full SHA for e05f4f0

• replace Registry.call('', []) with Registry.call('', ...[])

  Show description for 705aed6
  etpinard

  committed
  705aed6

  Copy full SHA for 705aed6

• no need for Registry in plot_api/to_image

  Show description for a851aa5
  etpinard

  committed
  a851aa5

  Copy full SHA for a851aa5