Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace es6-promise module with native-promise-only module #5358

Merged
merged 1 commit into from
Dec 25, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Dec 22, 2020

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you've tested IE11 with an async plot (MathJax perhaps) and it works, then this is great! 💃

@archmoj archmoj merged commit 278950b into master Dec 25, 2020
@archmoj archmoj deleted the replace-es6-promise branch December 25, 2020 03:54
@nicolaskruchten
Copy link
Contributor

From the readme of native-promise-only it's not clear to me if this supports IE11...?

@archmoj
Copy link
Contributor Author

archmoj commented Jan 4, 2021

native-promise-only

It does support IE11.
Have you noticed any particular problem?

@nicolaskruchten
Copy link
Contributor

No, I just read the documentation looking for a clear assertion of IE11 support and didn't find one, but if you're confident about your IE11 testing, this seems like a great solution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants