Add publish test for avoiding function constructors in non-gl(2d|3d) partial bundles #5383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcjohnson
reviewed
Jan 7, 2021
alexcjohnson
reviewed
Jan 7, 2021
package.json
Outdated
| @@ -31,6 +31,7 @@ | |||
| "watch": "node tasks/watch.js", | |||
| "lint": "eslint --version && eslint .", | |||
| "lint-fix": "eslint . --fix || true", | |||
| "no-new-func": "eslint --no-ignore --no-eslintrc --rule '{no-new-func: error}' dist/plotly-finance.js dist/plotly-basic.js dist/plotly-cartesian.js dist/plotly-geo.js dist/plotly-mapbox.js", | |||
There was a problem hiding this comment.
Nice simple command 🌟 I wonder though, is it possible to express this as a list of bundles to exclude - ie "test everything in dist/*js except *.min.js and plotly.js and plotly-gl3d.js and ..." that way over time we simply remove exclusions from the list, and any new bundle we create is automatically included?
alexcjohnson
reviewed
Jan 7, 2021
package.json
Outdated
| @@ -31,6 +31,7 @@ | |||
| "watch": "node tasks/watch.js", | |||
| "lint": "eslint --version && eslint .", | |||
| "lint-fix": "eslint . --fix || true", | |||
| "no-new-func": "eslint --debug --no-ignore --no-eslintrc --rule '{no-new-func: error}' $(ls dist/plotly*.js | grep -v plotly-locale* | grep -v plotly-gl* | grep -v plotly-with-meta.* | grep -v plotly.js | grep -v plotly.min.js)", | |||
There was a problem hiding this comment.
Nice! Probably don't need debug long-term, right? And I feel like we might as well include the locales in this test, for completeness... we know they're safe but wouldn't hurt to prove it.
alexcjohnson
approved these changes
Jan 7, 2021
|
There are also a number of function constructors in MathJax code:
|
|
let's exclude MathJax then, it's basically "not our problem" |
archmoj
deleted the
test-avoid-function-constructors-in-partial-bundles
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to #5358 and #5359 pull requests, most partial bundles namely
basic,cartesian,finance,geoandmapboxno longer have function constructors.This PR adds tests in
publishcontainer to lock this for future bundles.cc: #897
@plotly/plotly_js