Avoid function constructor in d3 #5359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archmoj
commented
Dec 22, 2020
alexcjohnson
approved these changes
Dec 27, 2020
archmoj
force-pushed
the
d3-v3-no-eval-func
branch
from
9f348eb to
d2f7269
Compare
|
This makes sense to me, and I still think we should stop exporting these functions and do a v2. |
|
Upon further reflection, although what I said above holds, there's no particular reason to do the v2 split immediately. I had initially thought that we would just not include the parts of d3v3 that use the function constructor, but if we're still exporting a fully-functional (although not up to Mike Bostock's performance standards!) version of d3v3 then we can just get on with things in a minor as usual. |
This was referenced Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #897 (comment)
[email protected](as well as d3-dsv use function constructors in the source.This PR suggests refactoring d3 to avoid using function constructors.
Demo
@plotly/plotly_js