Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More newPlot calls in tests #5393

Merged
merged 4 commits into from
Jan 12, 2021
Merged

More newPlot calls in tests #5393

merged 4 commits into from
Jan 12, 2021

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jan 11, 2021

Follow up of #5370.

@plotly/plotly_js

cc: #5395

@archmoj archmoj added this to the NEXT milestone Jan 11, 2021
var hoverData;
gd.on('plotly_hover', function(data) {
hoverData = data;
});

var pt = _hover(gd, 10, 100)[0];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch 🤦

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Beautiful!

@archmoj archmoj merged commit cecb4e5 into master Jan 12, 2021
@archmoj archmoj deleted the more-newPlot-in-tests branch January 12, 2021 18:02
@archmoj archmoj mentioned this pull request Jan 19, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants