Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Plotly.plot from the API #5412

Merged
merged 2 commits into from
Jan 16, 2021
Merged

Drop Plotly.plot from the API #5412

merged 2 commits into from
Jan 16, 2021

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jan 15, 2021 •
edited
Loading

Addressing #5395.
Thanks to #5370 and #5393.

TODO:

  • fix CI image test configuration to call Plotly.newPlot instead of Plotly.plot
  • maintain performance on the CI

@plotly/plotly_js

@archmoj archmoj added this to the NEXT milestone Jan 15, 2021
@antoinerg antoinerg self-assigned this Jan 15, 2021
@antoinerg
Copy link
Contributor

[ ] fix CI image test configuration to call Plotly.newPlot instead of Plotly.plot

Done in d688bba . ATM I can't really comment on stability / flakiness compared to what we had before.

alexcjohnson
alexcjohnson approved these changes Jan 16, 2021
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Excellent, glad we finally got that to work!

@archmoj archmoj merged commit 07fb7c3 into master Jan 16, 2021
@archmoj archmoj deleted the make-Plotly.plot-internal branch January 16, 2021 00:49
@peterblazejewicz peterblazejewicz mentioned this pull request Jul 6, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees

@antoinerg antoinerg

Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@archmoj @antoinerg @alexcjohnson