Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back roles with value object #5432

Merged
merged 7 commits into from
Jan 22, 2021
Merged

Bring back roles with value object #5432

merged 7 commits into from
Jan 22, 2021

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jan 22, 2021

In #5425 we drop all role keys.
In this PR we revert parts of the changes so that role: 'object' remains in the v2 API.
cc: #5395

@plotly/plotly_js

@archmoj archmoj added this to the NEXT milestone Jan 22, 2021
@archmoj archmoj requested a review from alexcjohnson January 22, 2021 16:15
alexcjohnson
alexcjohnson approved these changes Jan 22, 2021
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@archmoj archmoj merged commit f8f08cf into master Jan 22, 2021
@archmoj archmoj deleted the bring-back-object-role branch January 22, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@archmoj @alexcjohnson