Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid redundant plotly.js copyright comments in bundles #5439

Merged
merged 1 commit into from
Jan 23, 2021

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jan 22, 2021

Currently in each non-minified bundle there are 787 blocks of comments related to plotly.js headers.

The transform browserify task added in this PR help avoid this redundant info to endup in the bundles.

Here is a temporary commit to compare before and after diffs: 8c829a7

@plotly/plotly_js

@archmoj archmoj added this to the NEXT milestone Jan 22, 2021
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, might as well. 💃

@archmoj archmoj merged commit b854d61 into master Jan 23, 2021
@archmoj archmoj deleted the compress-headers branch January 23, 2021 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants