Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove copyright headers from source files #5446

Merged
merged 6 commits into from
Jan 27, 2021
Merged

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jan 27, 2021

The headers in the source files slightly complicated our development and build processes.
As discussed by @alexcjohnson

  • to avoid several redundant headers endup in the bundles without the costly browserify transform added in Avoid redundant plotly.js copyright comments in bundles #5439
  • to avoid test failures when new files are added without the header
  • to avoid a big PR every new year, and making every other open PR update to pass tests at the same time, annoying and potentially conflict-inducing for community PRs

This PR simplies all that by removing the headers from the src and lib folders.
To do so I adjusted the script in ee1aca8 and use that to make the changes.

cc: #5395

@plotly/plotly_js

@archmoj archmoj added this to the NEXT milestone Jan 27, 2021
@alexcjohnson
Copy link
Collaborator

licenseSrc is still used in

var cnt = [constants.licenseSrc, ''];

Is this desired? Looks like this is creating a file to be published so licenseDist may be more appropriate here?

@archmoj
Copy link
Contributor Author

archmoj commented Jan 27, 2021

licenseSrc is still used in

var cnt = [constants.licenseSrc, ''];

Is this desired? Looks like this is creating a file to be published so licenseDist may be more appropriate here?

Good call. Addressed in adbed4b.

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 LGTM!

@archmoj archmoj merged commit 8c5b725 into master Jan 27, 2021
@archmoj archmoj deleted the clear-src-headers branch January 27, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants