Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer inject MathJax config by default #5514

Merged
merged 8 commits into from
Feb 19, 2021
Merged

No longer inject MathJax config by default #5514

merged 8 commits into from
Feb 19, 2021

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Feb 18, 2021

cc: #5395

@plotly/plotly_js

@archmoj archmoj added this to the NEXT milestone Feb 18, 2021
inlineMath: [['$', '$'], ['\\(', '\\)']]
},
displayAlign: 'left',
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still want all of the code you removed from svg_text_utils - store the existing config, set our own, and replace the original config at the end. That way we get the config we want without interfering with anything the rest of the page might be doing.

@archmoj archmoj changed the title No longer inject and tweak MathJax config No longer inject MathJax config by default Feb 19, 2021
@archmoj archmoj requested a review from alexcjohnson February 19, 2021 15:01
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Love it.

@archmoj archmoj merged commit e65718e into master Feb 19, 2021
@archmoj archmoj deleted the mathjax-config branch February 19, 2021 20:47
@nicolaskruchten
Copy link
Contributor

@alexcjohnson this PR is the one that makes window.PlotlyConfig = {MathJaxConfig: 'local'} the default behaviour, correct?

@alexcjohnson
Copy link
Collaborator

Yes. window.PlotlyConfig is no longer a thing after this PR, and the sole behavior is what window.PlotlyConfig = {MathJaxConfig: 'local'} did previously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants