Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer inject MathJax config by default #5514

Merged
merged 8 commits into from
Feb 19, 2021
Merged

No longer inject MathJax config by default #5514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d49f5df
no more inject default MathJax config
archmoj Feb 18, 2021
721d634
no longer need to tweak mathjax config in texToSVG
archmoj Feb 18, 2021
0b3db23
adjust mathjax test
archmoj Feb 18, 2021
2ed1b02
using double dollar signs in mathjax mocks and update baselines
archmoj Feb 18, 2021
40a9a55
Revert "using double dollar signs in mathjax mocks and update baselines"
archmoj Feb 19, 2021
16410f9
Revert "no longer need to tweak mathjax config in texToSVG"
archmoj Feb 19, 2021
913b38f
edit comment in mathjax test
archmoj Feb 19, 2021
462d14b
use single dollar in mathjax test as before
archmoj Feb 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ require('native-promise-only');
// inject plot css
require('../build/plotcss');

// inject default MathJax config
require('./fonts/mathjax_config')();

// include registry module and expose register method
var Registry = require('./registry');
var register = exports.register = Registry.register;
Expand Down
21 changes: 0 additions & 21 deletions src/fonts/mathjax_config.js
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions test/jasmine/bundle_tests/mathjax_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@ describe('Test MathJax:', function() {
// N.B. we have to load MathJax "dynamically" as Karam
// does not undefined the MathJax's `?config=` parameter.
//
// Eventually, it might be nice to move these tests in the "regular" test
// Now with the mathjax_config no longer needed,
// it might be nice to move these tests in the "regular" test
// suites, but to do that we'll need to find a way to remove MathJax from
// page without breaking things downstream.
beforeAll(function(done) {
mathJaxScriptTag = document.createElement('script');
mathJaxScriptTag.type = 'text/javascript';
mathJaxScriptTag.onload = function() {
require('@src/fonts/mathjax_config')();
done();
};
mathJaxScriptTag.onerror = function() {
Expand Down