Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the list of traces for publishing packages to npm #5605

Merged
merged 1 commit into from
May 4, 2021

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Apr 22, 2021

I encountered missing lists when publishing v2.0.0-rc.1 to npm likey as a result of the changes in #5508.
This was fixed by providing the list of traces to syn_packages script as reflected in this PR.

@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable labels Apr 22, 2021
@archmoj archmoj added this to the NEXT milestone Apr 22, 2021
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@archmoj archmoj merged commit 7273e6d into master May 4, 2021
@archmoj archmoj deleted the fixup-sync-npm-packages branch May 4, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants