Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the list of traces for publishing packages to npm #5605

Merged
merged 1 commit into from
May 4, 2021
Merged

Fix the list of traces for publishing packages to npm #5605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions tasks/sync_packages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ partialBundlePaths
main: 'plotly-' + d.name + '.js',
dist: d.dist,
desc: 'Ready-to-use plotly.js ' + d.name + ' distributed bundle.',
traceList: constants.partialBundleTraces[d.name]
};
})
.concat([{
Expand All @@ -42,6 +43,7 @@ partialBundlePaths
main: 'plotly.js',
dist: constants.pathToPlotlyDist,
desc: 'Ready-to-use plotly.js distributed bundle.',
traceList: constants.allTraces
}])
.forEach(syncPartialBundlePkg);

Expand All @@ -54,6 +56,7 @@ partialBundlePaths
main: 'plotly-' + d.name + '.min.js',
dist: d.distMin,
desc: 'Ready-to-use minified plotly.js ' + d.name + ' distributed bundle.',
traceList: constants.partialBundleTraces[d.name]
};
})
.concat([{
Expand All @@ -62,6 +65,7 @@ partialBundlePaths
main: 'plotly.min.js',
dist: constants.pathToPlotlyDistMin,
desc: 'Ready-to-use minified plotly.js distributed bundle.',
traceList: constants.allTraces
}])
.forEach(syncPartialBundlePkg);

Expand Down Expand Up @@ -105,14 +109,12 @@ function syncPartialBundlePkg(d) {


function writeREADME(cb) {
var traceList = d.traceList;

var cnt = [
'# ' + d.name,
'',
d.desc,
'',
'Contains trace modules ' + common.formatEnumeration(traceList) + '.',
'Contains trace modules ' + common.formatEnumeration(d.traceList) + '.',
'',
'For more info on plotly.js, go to https://github.com/plotly/plotly.js',
'',
Expand Down
2 changes: 2 additions & 0 deletions tasks/util/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,8 @@ module.exports = {
pathToBuild: pathToBuild,
pathToDist: pathToDist,

partialBundleTraces: partialBundleTraces,

allTransforms: allTransforms,
allTraces: allTraces,
mainIndex: mainIndex,
Expand Down