-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking issue for removing react-motion
dependency
#667
Comments
Hi @Taelkir it's part of react-motion, here's the corresponding issue: chenglou/react-motion#569 |
Maby we should have a fork of the fix in the organization repo, the projet last commit was in 2018. |
I was just about to submit this same issue. It seems React Motion has been abandoned. |
There's an PR to fix this in react-motion: chenglou/react-motion#534. The initial hesitation was about compatability with React v14/15. But now it sounds like the project is somewhat abandoned. Other have mentioned successful transitions to react-spring: react-spring/react-spring. |
So what's the solution for it? I mean any alternatives or something like that? |
Perhaps if there were some examples of how a move to React-spring would look like for a package, we could do it incrementally? I'd be willing to do a package or 2, but I would like a little help as it seems that React-motion is firmly integrated into Nivo.. |
Maybe if there was a bounty on this it would help get things in motion... or should I say in spring? 😄 |
I stumbled upon this today while beginning to investigate Nivo as a replacement for our current dataviz approach, which is an ad hoc combination of several libraries (data-ui, victory, and react-vis). Our data-ui components are currently spewing warnings about It's not a great look for Nivo that my first experience is a deprecation warning from a library that is abandoned and hasn't been updated since 2017. Thankfully, the console warning doesn't appear if I disable animations, but still, it's 2020. Time to move to react-spring. |
I agree. It is a big change we are planning to make. Up until about a month ago, it was a single person managing the project. Now, I have been given some access to help merge PRs and manage issues. This is the second biggest issue we need to tackle. First, we are migrating the codebase to TS, which is in progress #821 and #963. After that is complete we will be tackling this. |
Bump. I've seen this warning as recently as yesterday, though I can double check my nivo and react versions later. |
Ended up on this issue from #1256. |
+1 here, looking to shift but am on React 17. Any update here? |
react-motion
dependency
react-motion
dependencyreact-motion
dependency
Bump, i have encountered the same warning , any workaround for the moment ? |
No workaround currently. |
Facing the same problem with the funnel, couldn't work around it. |
|
@daniellittledev, the problem is that |
|
Is this entirely blocking use of nivo when running React 17.x? Just hit a dep issue with react & react-motion whilst trying to use treemap. (Snipped CLI output log - can see |
@Nessworthy, you'll still get a warning but it should work. |
Migrated |
Migrated |
Removed from |
#1271 will remove it from |
Removed from @nivo/waffle in #2320. |
I'm getting the following console warning after upgrading to React 16.9.0
The above error is what I'm getting in my code, but I have recreated a similar warning in the console here: https://codesandbox.io/s/nivoline-line-layers-461-yogxd?fontsize=14
Only seems to happen to charts with custom tooltips - it doesn't appear for piecharts, but does if I render a choropleth or a line chart
Not sure if Motion/TransitionMotion are dependencies or part of Nivo.
Maintainer Edit: This is due to the
react-motion
package which is still used for some of the nivo packages, here is the list of packages still need to be migrated toreact-spring
:@nivo/core
to only support a@react-spring
config.react-motion
in the project/doc.The text was updated successfully, but these errors were encountered: