-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Waffle next #2320
Merged
Merged
Waffle next #2320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5d95efc:
|
12 tasks
This was referenced May 3, 2023
This was referenced May 21, 2024
This was referenced May 26, 2024
This was referenced Jun 3, 2024
This was referenced Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust
@nivo/waffle
to be more in line with other packages.🧰 Internal
@nivo/waffle
, upgradedjest
and enabled--workerThreads
for thepgks-test
make target.@nivo/grid
core package.@nivo/canvas
core package.🎉 Improvements
layers
.testIdPrefix
property, if specified, we're going to add adata-test-id
attribute to theWaffle
andWaffleHtml
components, to ease testing. Please note that it doesn't work forWaffleCanvas
as it has no concrete elements.recompose
anymore, finally 😅 (related to Tracking issue for removingrecompose
dependency #884).forwardLegendData
property, allowing users to implement custom legends.fillDirection
.lodash
anymore.borderRadius
on cells.💥 Breaking Changes 😢 (but still improvements for most of them 😄):
react-motion
and use@react-spring
instead, meaning that the config you can use is slightly different.This will help to resolve Tracking issue for removing
react-motion
dependency #667, but@nivo/core
should now only consider areact-spring
config, to be addressed in a different PR.areas
layer and use a custom cell component usingcellComponent
.data
is nowreadonly
.fillDirection
was defining the origin rather than the direction, which was a bit confusing, so things are now inverted, e.g,bottom
has the same behavior astop
in the previous version: