@nivo/waffle typescript migration #1271
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plouc
force-pushed
the
waffle-typescript-migration-reloaded
branch
from
111ed09 to
8024ac9
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 869045e:
|
…affleHtml components
…can override the tooltip to be consistent with newer implementations
…ng when checking if a cell is under the cursor
wyze
force-pushed
the
waffle-typescript-migration-reloaded
branch
from
4eac7a7 to
d42b37a
Compare
12 tasks
|
@plouc Is there anything I can do to help to get this one merged & complete the |
|
@MichaelDeBoey, it's been a while, iirc the main issue was reproducing the current animation achieved with react-motion. I didn't have much time to spend on side projects lately, I would need to investigate a little bit to answer that question 😓 |
|
@plouc Did you happen to already have some time to answer my question? |
|
superseded by #2320. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1245