Global: Responsive Display & Flexbox Props #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobGentile17
added
enhancement
There was a problem hiding this comment.
I moved the work you did over from globalProps.js to globalProps.ts in this PR fwiw. I tested things out with _image.tsx from that side.
|
Types have been updated from |
thestephenmarshall
changed the title
thestephenmarshall
force-pushed
the
responsive-flexbox-props2
branch
from
c527e95
to
604008f
Compare
thestephenmarshall
approved these changes
Apr 18, 2022
…lobal-responsive-display-props-in-all-kits
…lobal-responsive-display-props-in-all-kits
thestephenmarshall
force-pushed
the
responsive-flexbox-props2
branch
5 times, most recently
from
8d49ea0
to
fa37772
Compare
thestephenmarshall
force-pushed
the
responsive-flexbox-props2
branch
from
fa37772
to
bc5f0c1
Compare
thestephenmarshall
changed the title
thestephenmarshall
added
Ready for Release
jasperfurniss
added
the
milano
thestephenmarshall
force-pushed
the
responsive-flexbox-props2
branch
from
42c1fce
to
99d2792
Compare
jasoncypret
approved these changes
May 11, 2022
| $display_flex: flex; | ||
| $display_none: none; | ||
| $display_inline_flex: inline-flex; | ||
| $displays: ( |
| $align_content_values: ( |
There was a problem hiding this comment.
@RobGentile17 you're gonna love all this cleanup and simplification!
There was a problem hiding this comment.
I can't wait for it to be live and in use!
jasperfurniss
approved these changes
May 12, 2022
|
🚀 |
thestephenmarshall
force-pushed
the
master
branch
from
cc2d449
to
0c88584
Compare
thestephenmarshall
changed the title
thestephenmarshall
force-pushed
the
master
branch
2 times, most recently
from
8ff76c1
to
e79ba3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Responsive flexbox props works in rails but needs to be tweaked in react.
All flexbox props were added to typescript for convenience so those need to be tested:
Note Due to the large number of changes in #1846 conflicting with this PR originally, BOTH PRs exist here in this PR. The aforementioned PR will be closed after this one is merged.
Breaking Changes
No - new feature
Runway Ticket URL
https://nitro.powerhrg.com/runway/backlog_items/PLAY-4
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.Milanolabel when you are ready for a review.