Allow Responsive Display Global Props #1846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lobal-responsive-display-props-in-all-kits
…lobal-responsive-display-props-in-all-kits
…lobal-responsive-display-props-in-all-kits
diontheroulde
added
the
enhancement
RudeChowder
reviewed
Apr 29, 2022
thestephenmarshall
changed the title
thestephenmarshall
added
needs alpha testing
milano
…onsive-display-props-in-all-kits
thestephenmarshall
force-pushed
the
PLAY-33-Global-responsive-display-props-in-all-kits
branch
from
50a0645
to
de2ccbc
Compare
thestephenmarshall
approved these changes
May 4, 2022
thestephenmarshall
force-pushed
the
PLAY-33-Global-responsive-display-props-in-all-kits
branch
from
3d003c5
to
373783c
Compare
| @@ -28,3 +48,19 @@ $breakpoints: ( | |||
| @content; | |||
| } | |||
| } | |||
|
|
|||
| @mixin break_on($min: null, $max: null) { | |||
There was a problem hiding this comment.
This mixin will create a breakpoint grid with min and max sizes. This is the only way we could get the CSS declarations to apply.
| xl: ( | ||
| min: $screen-xl-min, | ||
| ) | ||
| ); |
There was a problem hiding this comment.
Relates to the break_on mixin
thestephenmarshall
added
the
Ready for Release
16 tasks
thestephenmarshall
changed the title
thestephenmarshall
deleted the
PLAY-33-Global-responsive-display-props-in-all-kits
branch
thestephenmarshall
added a commit
that referenced
this pull request
May 12, 2022
* Added conditional to displayProps * Added breakpoint query * Removed commented out code * Trying to display gloabl props * Display global props * Display breakpoints on rails * Working on multiple screen sizes * Display global props at multiple screen sizes * Added Props pill back for display * Separate base types * Fix display.rb css output * Global props work fro single display value * Edited visual guidelines styling * Fixed syntax for display.ts * Switched display.ts syntax back * Fixed syntax error this time * Fix types and SCSS classes * Add breakpoints grid to screen sizes * Don't make changes to unassociated files * All files should have one empty line at the end per code style rules * Add colors type Co-authored-by: Dion Theroulde <[email protected]> Co-authored-by: Stephen Marshall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screens
Breaking Changes
[Yes/No (Explain)]
Runway Ticket URL
https://nitro.powerhrg.com/runway/backlog_items/PLAY-33)
How to test this
[INSERT TESTING DETAILS]
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.Milanolabel when you are ready for a review.