[PLAY-277] Home ID in HomeAddressStreet should open in a new tab #2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts and created doc examples for each. Added new_window prop to the ruby hashtag component and created a new doc example for it
… doc examples for both rails and react for hashtag and homeaddresskit components
…and 32. link_option was the correct method to test for
…HomeAddressStreet
…ag so it dosnt mess with other tests
Israel-Molestina
added
enhancement
5 tasks
| @@ -49,7 +51,10 @@ const Hashtag = (props: HashtagProps) => { | |||
| className={classes} | |||
| id={id} | |||
| > | |||
| <a href={url}> | |||
| <a href={url} | |||
| rel="noreferrer" | |||
There was a problem hiding this comment.
Since this is an open source project, this really shouldn't be hard-coded here. You can add it as an optional prop then default the value, but we shouldn't dictate this part to everyone.
| state: "PA", | ||
| zipcode: "19382", | ||
| territory: "PHL", | ||
| }) %> |
There was a problem hiding this comment.
Suggested change
| }) %> | |
| }) %> | |
| @@ -0,0 +1 @@ | |||
| Use the newWindow/new_window prop to control whether the link opens on the same page or a new tab (same page is the default behavior) | |||
There was a problem hiding this comment.
Suggested change
| Use the newWindow/new_window prop to control whether the link opens on the same page or a new tab (same page is the default behavior) | |
| Use the `newWindow` / `new_window` prop to control whether the link opens on the same page or a new tab (same page is the default behavior). |
thestephenmarshall
approved these changes
Sep 7, 2022
Israel-Molestina
added
milano
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screens
Breaking Changes
NO
Runway Ticket URL
Runway Ticket URL
How to test this
cd playbook && ./test.sh
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.Milanolabel when you are ready for a review.