Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAY-259] Typescript Conversion: Home Address Street #2042

Merged
merged 3 commits into from
Sep 19, 2022
Merged

[PLAY-259] Typescript Conversion: Home Address Street #2042

merged 3 commits into from
Sep 19, 2022

Conversation

augustomallmann
Copy link
Contributor

Screens

Screen Shot 2022-08-31 at 1 27 51 PM

Breaking Changes

No breaking changes, but it modifies the typing of homeId prop from number to string. This had to be done because this prop is passed to the hashtag component, that only accepts string.

do not merge until this PR gets approved. They will need to be merged and its conflicts solved.

Runway Ticket URL

PLAY-259

How to test this

Start the server and check if all components are rendering correctly. There should be no console errors. Try using the kit with different props.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@augustomallmann augustomallmann added milano 20 MAX - Deploy this PR to a review environment via Milano do not merge typescript labels Aug 31, 2022
@augustomallmann augustomallmann requested a review from a team as a code owner August 31, 2022 16:33
@app-milano app-milano bot temporarily deployed to pr2042 August 31, 2022 16:52 Inactive
@augustomallmann augustomallmann added the enhancement New Features, Props, & Variants (USED IN CHANGELOG) label Aug 31, 2022
@augustomallmann augustomallmann requested a review from nidaqg August 31, 2022 20:13
@augustomallmann
Copy link
Contributor Author

  • jest tests

@app-milano app-milano bot temporarily deployed to pr2042 September 1, 2022 18:33 Inactive
@augustomallmann augustomallmann added milano 20 MAX - Deploy this PR to a review environment via Milano and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels Sep 14, 2022
@jasperfurniss jasperfurniss merged commit 5a21c49 into master Sep 19, 2022
@jasperfurniss jasperfurniss deleted the typescript-home-adress-street branch September 19, 2022 17:03
@jasperfurniss jasperfurniss added the Ready for Release merged to master, ready for a versioned released label Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thestephenmarshall thestephenmarshall thestephenmarshall approved these changes

@jasperfurniss jasperfurniss jasperfurniss approved these changes

@Israel-Molestina Israel-Molestina Israel-Molestina approved these changes

@nidaqg nidaqg Awaiting requested review from nidaqg

Assignees

@augustomallmann augustomallmann

Labels
enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@augustomallmann @thestephenmarshall @jasperfurniss @Israel-Molestina