Convert legacy total score to standardised when importing high scores #135
Conversation
| case 0: | ||
| case 1: | ||
| case 2: | ||
| // In these rulesets, every mod combination has the same max combo. So use the attribute with mods=0. | ||
| break; | ||
|
|
||
| case 3: | ||
| // In mania, only keymods affect the number of objects and thus the max combo. | ||
| difficultyMods = highScore.enabled_mods & (int)LegacyModsHelper.KEY_MODS; | ||
| break; |
There was a problem hiding this comment.
I don't really know why this switch existed. The max combo appears to be identical for non-keymod mania difficulties too.
I believe this may have been legacy code...
|
Just for reference, as far as I can tell, this will also fix an issue reported on discord today about realtime imports of stable scores not having mod multipliers applied. Current |
|
@peppy I want to test SR/PP changes ppy/osu#22613 and ppy/osu#20963 and I need this PR + ppy/osu-difficulty-calculator#221 merged otherwise it gets messy dealing with multiple working trees. |
| @@ -58,7 +57,6 @@ public async Task<int> OnExecuteAsync(CancellationToken cancellationToken) | |||
| foreach (var score in scores) | |||
| { | |||
| bool requiresUpdate = ensureMaximumStatistics(score); | |||
| requiresUpdate |= ensureCorrectTotalScore(score); | |||
There was a problem hiding this comment.
Does this command even make sense anymore?
|
Haven't tested running this, but I think we can move forward for now. |
Prereqs:
osu.GamebumpOne questionable/important aspect is that we don't store difficulty attributes for all mod combinations. For example, for +HDHR, we only store the difficulty attributes for +HR. Because of this, there's an extra step here that re-multiplies the
LegacyComboScorewith the correct mod multiplier.This could result in an off-by-one score for each hitobject because legacy scoring truncates at every judgement, that adds up over time. For example, chocomint's score on
FREEDOM DiVE [FOUR DIMENSIONS]converts to1116538when imported via this process, but1116540when imported directly from replay into lazer.I've taken the liberty to treat this small discrepancy as acceptable.
Required database attributes:
We must re-run the difficulty calculator across all ranked beatmaps on all rulesets prior to any new import, with the osu-side changes applied.