Allow modification of menu keybindings #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilRunninger
requested changes
Nov 28, 2018
There was a problem hiding this comment.
Two more things:
- adjust the
j/ktext in https://github.com/scrooloose/nerdtree/blob/master/lib/nerdtree/menu_controller.vim#L52 - Document the new variables in https://github.com/scrooloose/nerdtree/blob/master/doc/NERDTree.txt.
|
Reasonable. Will add the changes later today. |
Leandros
force-pushed
the
master
branch
2 times, most recently
from
3f8c22e
to
ff56a9f
Compare
|
Incorporated your suggestions. Although, I didn't update the |
|
That text needs to change. The default is echo "NERDTree Menu. Use " . g:NERDTreeMenuDown . "/" . g:NERDTreeMenuUp . "/enter and the shortcuts indicated" |
|
Ahh, I didn't think of that. Makes sense. |
|
Fixed. |
|
Excellent! Thanks for the contribution, @Leandros. |
|
Thank you for NERDTree! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My keyboard layout has different keys on 'j' & 'k'. This allows changing the defaults.