-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Modification request] All links to be blue #770
Comments
Issue (internal link) for the feature pages. |
Thanks for kicking this off 🙏 |
Thanks @nsolerieu — consistency makes sense to me! I'd be keen to get @danielguillan's thoughts on this as I don't have historical context on whether the differing colours are an oversight, or an intentional choice |
Yeah I'm in for consistency — @danielguillan let me know if you have more context here |
The different colors were intentional but purely aesthetic choices based on the page designs these components supported when they were introduced. I also recommend updating these to use blue by default. There is at least one additional component that doesn't use blue links, and we should consider it as well: SectionIntro. |
I'm supportive of making links blue globally and by default. |
👋 Checking in to see how far we want to go with this change? We have many links on the site. Presumably we are only targeting this specific compoinent and not all links? For some historical context, links in Rivers were changed to black (from blue) during Site Refactor to address hierarchical issues with adjacent CTAs. Link to Refactor design file. I believe that's also why SubNav, Breadcrumbs and other components use black links by default over blue ones. I think we should selectively apply this change to our most prominent high-level patterns, where link competition is less of a concern. There's a PR open now to update Wondering if we also want to update the following, as they were intentionally designed to default to black? |
Re-opening due to:
|
Update: Figma changes have now shipped. No additional scope added. |
Hey @rezrah just double checking on your comment above. All links to be blue for river components, text blocks, etc. The ones you mentioned above are okay to stay black by default.
I just want to make sure, it's the reverse. We are pivoting from black OR white to blue link colors. |
👍 yes that's correct. Links in River and Section Intro have been changed to blue now. Example from our docs.. Sorry I wasn't clear earlier. In my earlier comment I am referring to the reason why River's previously had black links. It was a change made during the Site Refactor update. |
Context
During the refactoring of our feature pages we've been using lots of rivers, pillars, cards, bento with links. The inconsistent color has been noticed at many occasion by different stakeholders.
River
links are black/whiteCards
links are blueDesign suggestion
Align all components that have links to default to blue links with the following exceptions:
The text was updated successfully, but these errors were encountered: