Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modification request] All links to be blue #770

Closed
nsolerieu opened this issue Sep 25, 2024 · 11 comments · Fixed by #811
Closed

[Modification request] All links to be blue #770

nsolerieu opened this issue Sep 25, 2024 · 11 comments · Fixed by #811
Assignees

Comments

@nsolerieu
Copy link
Contributor

nsolerieu commented Sep 25, 2024

Context

During the refactoring of our feature pages we've been using lots of rivers, pillars, cards, bento with links. The inconsistent color has been noticed at many occasion by different stakeholders.

  • River links are black/white
    Image

  • Cards links are blue
    Image

Design suggestion

Align all components that have links to default to blue links with the following exceptions:

  • Bentos that have a background image or a background gradient in use:
    Image
@simurai
Copy link
Contributor

simurai commented Sep 26, 2024

Issue (internal link) for the feature pages.

@samoshin
Copy link

Thanks for kicking this off 🙏

@joshfarrant
Copy link
Contributor

Thanks @nsolerieu — consistency makes sense to me!

I'd be keen to get @danielguillan's thoughts on this as I don't have historical context on whether the differing colours are an oversight, or an intentional choice

@tallys
Copy link

tallys commented Oct 4, 2024

Yeah I'm in for consistency — @danielguillan let me know if you have more context here

@danielguillan
Copy link
Contributor

The different colors were intentional but purely aesthetic choices based on the page designs these components supported when they were introduced. I also recommend updating these to use blue by default.

There is at least one additional component that doesn't use blue links, and we should consider it as well: SectionIntro.

@samoshin
Copy link

There is at least one additional component that doesn't use blue links, and we should consider it as well: SectionIntro.

I'm supportive of making links blue globally and by default.

@rezrah
Copy link
Collaborator

rezrah commented Nov 5, 2024

👋 Checking in to see how far we want to go with this change?

We have many links on the site. Presumably we are only targeting this specific compoinent and not all links?

Image

For some historical context, links in Rivers were changed to black (from blue) during Site Refactor to address hierarchical issues with adjacent CTAs. Link to Refactor design file.

I believe that's also why SubNav, Breadcrumbs and other components use black links by default over blue ones.

I think we should selectively apply this change to our most prominent high-level patterns, where link competition is less of a concern.

There's a PR open now to update River and SectionIntro to use blue links, as these fit that criteria and were called out in the discussion above 👍

Wondering if we also want to update the following, as they were intentionally designed to default to black?

@rezrah rezrah self-assigned this Nov 5, 2024
@rezrah
Copy link
Collaborator

rezrah commented Nov 5, 2024

Re-opening due to:

@rezrah rezrah reopened this Nov 5, 2024
@rezrah
Copy link
Collaborator

rezrah commented Nov 10, 2024

Update: Figma changes have now shipped. No additional scope added.

@rezrah rezrah closed this as completed Nov 10, 2024
@jesussandreas
Copy link

Hey @rezrah just double checking on your comment above.

All links to be blue for river components, text blocks, etc. The ones you mentioned above are okay to stay black by default.

For some historical context, links in Rivers were changed to black (from blue)

I just want to make sure, it's the reverse. We are pivoting from black OR white to blue link colors.

@jesussandreas jesussandreas reopened this Nov 12, 2024
@rezrah
Copy link
Collaborator

rezrah commented Nov 12, 2024

For some historical context, links in Rivers were changed to black (from blue)

I just want to make sure, it's the reverse. We are pivoting from black OR white to blue link colors.

👍 yes that's correct. Links in River and Section Intro have been changed to blue now. Example from our docs..

Sorry I wasn't clear earlier. In my earlier comment I am referring to the reason why River's previously had black links. It was a change made during the Site Refactor update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

8 participants