Rename and move color mode variables out of base package #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fa32602 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
simurai
reviewed
Jun 15, 2021
There was a problem hiding this comment.
👍
Type: Minor
Should this be changed to a major release?
I guess minor is ok for sites/apps that load the /index.scss. But it would break when core/index.scss is loaded stand-alone because the color variables would not be available anymore. E.g. helphub.
Yeah I agree, it was something I wasn't sure about. |
jonrohan
added a commit
that referenced
this pull request
Sep 17, 2021
* Adding pre mode * Updating the workflows * Update README.md * Create proud-rules-wonder.md * Rename and move color mode variables out of base package (#1462) * Rename and move color mode variables out of base package * Create mighty-goats-teach.md * Add test to make sure support is never more than 0 * Update mighty-goats-teach.md * Update mighty-goats-teach.md * Remove test * Delete patch * Moving color modes to their own bundle (#1465) * Moving color modes to their own bundle * Create new-beers-peel.md * Removing the rem() mixin and usages. Placing the computed values in place. (#1541) * Removing the rem() mixin and usages. Placing the computed values in place. * Create flat-shirts-lay.md * Fixing stylelint issues * Fix more stylelint issue * Remove break-word from utilities (#1566) * Remove break-word from utilities * Create twelve-fireants-shave.md * Adding dark high contrast * Fixing mising color modes selectors * Remove pre.json if it exists * Fixing lint error * Removing pre mode Co-authored-by: simurai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all of our color modes variables are included in the
base/index.scsspackage. This pr moves themodes.scssfiles to the support/variables folder and imports them directly intoprimer/css/index. I'm not importing them into support/index because that package is meant to compile to nothing since it's being used in a lot of packages.This is solving a few things: