Removing the rem() mixin and usages. Placing the computed values in place. #1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 90a7e08 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
simurai
approved these changes
Aug 19, 2021
|
Yesss this looks good. Agree that we can refine this, but looks OK to ship as is ☀️ |
tobiasahlin
approved these changes
Aug 19, 2021
simurai
approved these changes
Aug 23, 2021
jonrohan
added a commit
that referenced
this pull request
Sep 17, 2021
* Adding pre mode * Updating the workflows * Update README.md * Create proud-rules-wonder.md * Rename and move color mode variables out of base package (#1462) * Rename and move color mode variables out of base package * Create mighty-goats-teach.md * Add test to make sure support is never more than 0 * Update mighty-goats-teach.md * Update mighty-goats-teach.md * Remove test * Delete patch * Moving color modes to their own bundle (#1465) * Moving color modes to their own bundle * Create new-beers-peel.md * Removing the rem() mixin and usages. Placing the computed values in place. (#1541) * Removing the rem() mixin and usages. Placing the computed values in place. * Create flat-shirts-lay.md * Fixing stylelint issues * Fix more stylelint issue * Remove break-word from utilities (#1566) * Remove break-word from utilities * Create twelve-fireants-shave.md * Adding dark high contrast * Fixing mising color modes selectors * Remove pre.json if it exists * Fixing lint error * Removing pre mode Co-authored-by: simurai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rem()mixin is holding back the codebase from upgrading todart-sass. #1452 (comment)node-sasshas reached end of life and is no longer supported by sass. But we can't migrate until we remove alla / bmath from the codebase. There's issues migrating this mixin so we'd like to remove it.I've searched for the places this mixin is used and replaced with the computed values for these marketing buttons. I'd like to put this in the next major release and then, if it's necessary, add to the dotcom codebase in case any code there uses the mixin.
@tobiasahlin @simurai do you see any problems with this plan?